F.A.
F.A.

Reputation: 623

Android - Shared element transitions with calling activity finish()

I'm working on making an application more Material and I'm just stuck on how to implement some shared element transitions. I have an activity A that starts another B and then calls finish() in order to remove it from the back stack. In my case I have an element I want to share between the two activities, but once it is passed from A to B, A no longer matters. If I don't call finish() after startActivity(ctx,intent, bundle) the exit/enter animation works perfectly. However, if I do call finish, there's a really ugly flicker before the animation starts.

Is there something I'm overlooking or is it just not possible to do what I am trying to do?

Upvotes: 31

Views: 12781

Answers (6)

florianmski
florianmski

Reputation: 5643

I've written a variation of this answer which I find a bit more elegant as you don't need a field.
This is still far from ideal but it works in my use case which is basically a splash screen with a transition to the next screen and I want the splash screen to be closed right away. This works because onStop is called when the activity is not visible anymore, thus at that point we can actually close it without causing artifacts (in this case this blinking / flickering)

lifecycle.addObserver(object : LifecycleEventObserver {
    override fun onStateChanged(source: LifecycleOwner, event: Lifecycle.Event) {
        if (event == Lifecycle.Event.ON_STOP) {
            lifecycle.removeObserver(this)
            finish()
        }
    }
})

Upvotes: 4

6rchid
6rchid

Reputation: 1292

If you use ActivityOptions.makeSceneTransitionAnimation(Activity, android.view.View, String) to make your transition you should use its callback method in Activity B to finish Activity A.

    setEnterSharedElementCallback(new SharedElementCallback() {
        @Override
        public void onSharedElementEnd(List<String> sharedElementNames, List<View> sharedElements, List<View> sharedElementSnapshots) {
            super.onSharedElementEnd(sharedElementNames, sharedElements, sharedElementSnapshots);
                // finish Activity A

        }
    });

Upvotes: 2

l-l
l-l

Reputation: 3854

You can finish your activity in the onStop function, if you only want this to happen when you transition from A to B then create a flag and set it after you call startActivity(ctx,intent, bundle):

@Override
public void onStop() {
    super.onStop();
    if(mShouldFinish)
         finish();
}

Make sure when you are done with activity B to call finish() and not finishAfterTranstion() since activity A is no longer there

After finishing the activity A, shared element in B might hang in screen if you press back. Set transitionName to null in ActivityB.onEnterAnimationComplete to avoid this.

Upvotes: 31

ahmed_khan_89
ahmed_khan_89

Reputation: 2773

This is maybe late but I had the same issue. What worked for me is:

supportFinishAfterTransition();

This is included in the support library and works like charm.

PS: you don't needto call finish() when you call supportFinishAfterTransition() .

Upvotes: 7

Karthik Rk
Karthik Rk

Reputation: 727

Try out finishAfterTransition() method in 5.0 and above you can finish the activity after the exit transition occurs.

Upvotes: 3

ksarmalkar
ksarmalkar

Reputation: 1894

UPDATE

Much better and simpler way

ActivityCompat. finishAfterTransition(this);

<3 support library.

Upvotes: 31

Related Questions