Reputation: 4936
RxJava update data from Observable
I have 2 listview's. It contains text items. I want to drag text item from left list and drop to right list. Whith This I have no problem. Also, I have an Observable, which emmits KalturaVideo objects. Here is code how I getting this observable: This function get's id of already added in right listview, and excludes object from result, if object id equals to some id from targetList:
private Observable<KalturaVideo> getSourceListObservalbe(String kalturaPlaylistId){
Observable<String[]> targetIdList = Observable.just(targetList)
.map((List<KalturaVideo> kalturaVideos) -> {
if(kalturaVideos == null || kalturaVideos.isEmpty()){
return new String[]{""};
}
String[] result = new String[kalturaVideos.size()];
int index = 0;
for (KalturaVideo item : kalturaVideos) {
result[index] = item.getId();
}
return result;
});
return Observable.combineLatest(
targetIdList,
KalturaVideoRetriver.getVideoList(BuildPlaylistStep2Activity.this, kalturaPlaylistId),
(String[] idListOfTarget, KalturaVideo kalturaVideo) -> {
for (String item :idListOfTarget){
if(item.equals(kalturaVideo.getId())){
return null;
}
}
return kalturaVideo;
})
.doOnError(throwable -> {
int i =0;
i++;
throwable.printStackTrace();
})
.filter(kalturaVideo -> {
return kalturaVideo != null;
});
}
Here is a code of video retriver:
public class KalturaVideoRetriver {
public static final String KALTURA_NEW_PLAYLIST_ID = "NEW_PLAYLIST";
public static Observable<KalturaVideo> getVideoList(Context context, String kalturaPlaylistId){
return Observable.create(new Observable.OnSubscribe<KalturaVideo>() {
@Override
public void call(Subscriber<? super KalturaVideo> subscriber) {
getKalturaPlaylistContentObservable(kalturaPlaylistId, context)
.flatMap(new Func1<String[], Observable<?>>() {
@Override
public Observable<?> call(String[] videoIdList) {
return getKalturaVideoListObservable(context, videoIdList)
.doOnNext(kalturaVideo -> {
subscriber.onNext(kalturaVideo);
})
.doOnCompleted(() -> subscriber.onCompleted());
}
})
.subscribe();
}
});
}
private static Observable<KalturaVideo> getKalturaVideoListObservable(Context context, String[] kalturaVideoIdArray){
return Observable.create(new Observable.OnSubscribe<KalturaVideo>() {
@Override
public void call(Subscriber<? super KalturaVideo> subscriber) {
Cursor query;
List<KalturaVideo> result = new ArrayList<>();
if(kalturaVideoIdArray == null || kalturaVideoIdArray.length == 0) {
query = context.getContentResolver().query(KalturaVideoColumns.CONTENT_URI, null, null, null, null);
}else {
KalturaVideoSelection where = new KalturaVideoSelection();
where.kalturaIdLike(kalturaVideoIdArray);
query = context.getContentResolver().query(
KalturaVideoColumns.CONTENT_URI,
null,
where.sel(),
where.args(),
null);
}
if(!query.moveToFirst()){
query.close();
subscriber.onCompleted();
}
KalturaVideoCursor cursor = new KalturaVideoCursor(query);
do{
KalturaVideo video = new KalturaVideo();
video.setId(cursor.getKalturaId());
video.setName(cursor.getName());
video.setDescription(cursor.getDescription());
video.setCategories(cursor.getCategories());
video.setCategoriesIds(cursor.getCategoriesIds());
video.setDownloadUrl(cursor.getDownloadUrl());
video.setThumbnailUrl(cursor.getThumbnailUrl());
video.setDataUrl(cursor.getDataUrl());
video.setDuration(cursor.getDuration());
subscriber.onNext(video);
}while (cursor.moveToNext());
query.close();
subscriber.onCompleted();
}
});
}
private static Observable<String[]> getKalturaPlaylistContentObservable(String kalturaPlaylistId, Context context){
return Observable.create(new Observable.OnSubscribe<String[]>() {
@Override
public void call(Subscriber<? super String[]> subscriber) {
if(kalturaPlaylistId.equals(KALTURA_NEW_PLAYLIST_ID)){
subscriber.onNext(new String[]{});
subscriber.onCompleted();
return;
}
KalturaPlaylistContentSelection where = new KalturaPlaylistContentSelection();
where.playlistId(kalturaPlaylistId);
Cursor query = context.getContentResolver().query(
KalturaPlaylistContentColumns.CONTENT_URI,
null,
where.sel(),
where.args(),
null
);
if(!query.moveToFirst()){
subscriber.onNext(new String[]{});
query.close();
subscriber.onCompleted();
return;
}
KalturaPlaylistContentCursor cursor = new KalturaPlaylistContentCursor(query);
String[] result = new String[query.getCount()];
int index = 0;
do{
result[index] = cursor.getKalturaVideoId();
index++;
}while (query.moveToNext());
query.close();
subscriber.onNext(result);
subscriber.onCompleted();
}
});
}
}
first of all, in retriver, I gettting video id's by playlist id. If PlaylistId is empty - I get all videos id's, which stored in my db. After this I getting all videos from db by id's, which i get at previous step.
Here is function, which helps me to get all videos and display it:
private Observable<KalturaVideo> fillLists(){
return getSourceListObservalbe(KalturaVideoRetriver.KALTURA_NEW_PLAYLIST_ID)
.subscribeOn(Schedulers.io())
.observeOn(AndroidSchedulers.mainThread())
.doOnError(throwable -> {
Log.e("TAG", throwable.getCause().toString());
})
.doOnNext(kalturaVideo -> {
sourceList.add(kalturaVideo);
})
.doOnCompleted(() -> {
viewHolder.sourceListView.setAdapter(new BuildPlaylistContentAdapter(
BuildPlaylistStep2Activity.this,
-1,
sourceList));
viewHolder.sourceListView.setOnItemLongClickListener(new AdapterView.OnItemLongClickListener() {
@Override
public boolean onItemLongClick(AdapterView<?> parent, View view, int position, long id) {
KalturaVideo video = (KalturaVideo) view.getTag();
ClipData data = ClipData.newPlainText("kalturaVideoId", video.getId());
View.DragShadowBuilder shadowBuilder = new View.DragShadowBuilder(view);
view.startDrag(data, shadowBuilder, view, 0);
view.setVisibility(View.INVISIBLE);
return false;
}
});
viewHolder.targetListView.setAdapter(new BuildPlaylistContentAdapter(
BuildPlaylistStep2Activity.this,
-1,
targetList
));
});
}
And here is how I sibscribe on it:
subscription = fillLists().subscribe();
Here is, how I trying to update 2 lists after drag and drop:
targetList.add(video);
sourceList.clear();
fillLists().subscribe();
where video - is video related to view, which was dropped to new list.
So, when I dropped view to another list first time, it works fine. But when I drop second time, I get this stacktrace in my doOnError method:
04-20 18:46:02.072 8015-8083/com.mediamanagment.app W/System.err﹕ java.lang.NullPointerException 04-20 18:46:02.072
8015-8083/com.mediamanagment.app W/System.err﹕ at com.mediamanagment.app.activity.BuildPlaylistStep2Activity.lambda$getSourceListObservalbe$3(BuildPlaylistStep2Activity.java:106) 04-20 18:46:02.072 8015-8083/com.mediamanagment.app W/System.err﹕ at com.mediamanagment.app.activity.BuildPlaylistStep2Activity.access$lambda$1(BuildPlaylistStep2Activity.java) 04-20 18:46:02.072 8015-8083/com.mediamanagment.app W/System.err﹕ at com.mediamanagment.app.activity.BuildPlaylistStep2Activity$$Lambda$2.call(Unknown Source) 04-20 18:46:02.080 8015-8083/com.mediamanagment.app W/System.err﹕ at rx.functions.Functions$3.call(Functions.java:76) 04-20 18:46:02.080 8015-8083/com.mediamanagment.app W/System.err﹕ at rx.operators.OperatorCombineLatest$Collector.next(OperatorCombineLatest.java:157) 04-20 18:46:02.080 8015-8083/com.mediamanagment.app W/System.err﹕ at rx.operators.OperatorCombineLatest$SourceSubscriber.onNext(OperatorCombineLatest.java:218) 04-20 18:46:02.080 8015-8083/com.mediamanagment.app W/System.err﹕ at com.mediamanagment.app.retrivers.KalturaVideoRetriver$1$1.lambda$call$13(KalturaVideoRetriver.java:36) 04-20 18:46:02.080 8015-8083/com.mediamanagment.app W/System.err﹕ at com.mediamanagment.app.retrivers.KalturaVideoRetriver$1$1.access$lambda$0(KalturaVideoRetriver.java) 04-20 18:46:02.080 8015-8083/com.mediamanagment.app W/System.err﹕ at com.mediamanagment.app.retrivers.KalturaVideoRetriver$1$1$$Lambda$1.call(Unknown Source) 04-20 18:46:02.080 8015-8083/com.mediamanagment.app W/System.err﹕ at rx.Observable$12.onNext(Observable.java:3682) 04-20 18:46:02.080 8015-8083/com.mediamanagment.app W/System.err﹕ at rx.operators.OperatorDoOnEach$1.onNext(OperatorDoOnEach.java:61) 04-20 18:46:02.080 8015-8083/com.mediamanagment.app W/System.err﹕ at com.mediamanagment.app.retrivers.KalturaVideoRetriver$2.call(KalturaVideoRetriver.java:80) 04-20 18:46:02.080 8015-8083/com.mediamanagment.app W/System.err﹕ at com.mediamanagment.app.retrivers.KalturaVideoRetriver$2.call(KalturaVideoRetriver.java:47) 04-20 18:46:02.080 8015-8083/com.mediamanagment.app W/System.err﹕ at rx.Observable$2.call(Observable.java:153) 04-20 18:46:02.080
8015-8083/com.mediamanagment.app W/System.err﹕ at rx.Observable$2.call(Observable.java:149) 04-20 18:46:02.080
8015-8083/com.mediamanagment.app W/System.err﹕ at rx.Observable$2.call(Observable.java:153) 04-20 18:46:02.080
8015-8083/com.mediamanagment.app W/System.err﹕ at rx.Observable$2.call(Observable.java:149) 04-20 18:46:02.080
8015-8083/com.mediamanagment.app W/System.err﹕ at rx.Observable.unsafeSubscribe(Observable.java:6110) 04-20 18:46:02.080 8015-8083/com.mediamanagment.app W/System.err﹕ at rx.operators.OperatorMerge$1.onNext(OperatorMerge.java:66) 04-20 18:46:02.080 8015-8083/com.mediamanagment.app W/System.err﹕ at rx.operators.OperatorMerge$1.onNext(OperatorMerge.java:43) 04-20 18:46:02.080 8015-8083/com.mediamanagment.app W/System.err﹕ at rx.operators.OperatorMap$1.onNext(OperatorMap.java:54) 04-20 18:46:02.080 8015-8083/com.mediamanagment.app W/System.err﹕ at com.mediamanagment.app.retrivers.KalturaVideoRetriver$3.call(KalturaVideoRetriver.java:93) 04-20 18:46:02.080 8015-8083/com.mediamanagment.app W/System.err﹕ at com.mediamanagment.app.retrivers.KalturaVideoRetriver$3.call(KalturaVideoRetriver.java:89) 04-20 18:46:02.080 8015-8083/com.mediamanagment.app W/System.err﹕ at rx.Observable$2.call(Observable.java:153) 04-20 18:46:02.080
8015-8083/com.mediamanagment.app W/System.err﹕ at rx.Observable$2.call(Observable.java:149) 04-20 18:46:02.080
8015-8083/com.mediamanagment.app W/System.err﹕ at rx.Observable$2.call(Observable.java:153) 04-20 18:46:02.088
8015-8083/com.mediamanagment.app W/System.err﹕ at rx.Observable$2.call(Observable.java:149) 04-20 18:46:02.088
8015-8083/com.mediamanagment.app W/System.err﹕ at rx.Observable.subscribe(Observable.java:6177) 04-20 18:46:02.088
8015-8083/com.mediamanagment.app W/System.err﹕ at rx.Observable.subscribe(Observable.java:5842) 04-20 18:46:02.088
8015-8083/com.mediamanagment.app W/System.err﹕ at com.mediamanagment.app.retrivers.KalturaVideoRetriver$1.call(KalturaVideoRetriver.java:41) 04-20 18:46:02.088 8015-8083/com.mediamanagment.app W/System.err﹕ at com.mediamanagment.app.retrivers.KalturaVideoRetriver$1.call(KalturaVideoRetriver.java:27) 04-20 18:46:02.088 8015-8083/com.mediamanagment.app W/System.err﹕ at rx.Observable.unsafeSubscribe(Observable.java:6110) 04-20 18:46:02.095 8015-8083/com.mediamanagment.app W/System.err﹕ at rx.operators.OperatorCombineLatest.call(OperatorCombineLatest.java:87) 04-20 18:46:02.095 8015-8083/com.mediamanagment.app W/System.err﹕ at rx.operators.OperatorCombineLatest.call(OperatorCombineLatest.java:40) 04-20 18:46:02.095 8015-8083/com.mediamanagment.app W/System.err﹕ at rx.Observable$2.call(Observable.java:153) 04-20 18:46:02.095
8015-8083/com.mediamanagment.app W/System.err﹕ at rx.Observable$2.call(Observable.java:149) 04-20 18:46:02.095
8015-8083/com.mediamanagment.app W/System.err﹕ at rx.Observable$2.call(Observable.java:153) 04-20 18:46:02.095
8015-8083/com.mediamanagment.app W/System.err﹕ at rx.Observable$2.call(Observable.java:149) 04-20 18:46:02.095
8015-8083/com.mediamanagment.app W/System.err﹕ at rx.Observable.unsafeSubscribe(Observable.java:6110) 04-20 18:46:02.095 8015-8083/com.mediamanagment.app W/System.err﹕ at rx.operators.OperatorSubscribeOn$1$1.call(OperatorSubscribeOn.java:60) 04-20 18:46:02.095 8015-8083/com.mediamanagment.app W/System.err﹕ at rx.schedulers.NewThreadScheduler$NewThreadWorker$ScheduledAction.run(NewThreadScheduler.java:141) 04-20 18:46:02.095 8015-8083/com.mediamanagment.app W/System.err﹕ at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:390) 04-20 18:46:02.095 8015-8083/com.mediamanagment.app W/System.err﹕ at java.util.concurrent.FutureTask.run(FutureTask.java:234) 04-20 18:46:02.095 8015-8083/com.mediamanagment.app W/System.err﹕ at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:153) 04-20 18:46:02.103 8015-8083/com.mediamanagment.app W/System.err﹕ at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:267) 04-20 18:46:02.103 8015-8083/com.mediamanagment.app W/System.err﹕ at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1080) 04-20 18:46:02.103 8015-8083/com.mediamanagment.app W/System.err﹕ at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:573) 04-20 18:46:02.103 8015-8083/com.mediamanagment.app W/System.err﹕ at java.lang.Thread.run(Thread.java:856)
And nothing videos was returned
Upvotes: 1
Views: 1515
Answers (1)
Reputation: 11515
you've got an NullPointerException in this code
Log.e("TAG", throwable.getCause().toString());
I think that your exception doesn't have a cause, so the toString call throw a NPE (NullPointerException)
Replace your code with
Log.e("TAG", throwable.getCause());
It should fix this issue
BUT your code is very complex, and some parts can be writen in a different way. Some other a buggy.
For example :
Bug
.doOnError(throwable -> {
int i =0;
i++;
throwable.printStackTrace();
})
i will always be equal to 0 (or 1 after i++). Is it voluntary ?
Bad code
public static Observable<KalturaVideo> getVideoList(Context context, String kalturaPlaylistId){
return Observable.create(new Observable.OnSubscribe<KalturaVideo>() {
@Override
public void call(Subscriber<? super KalturaVideo> subscriber) {
getKalturaPlaylistContentObservable(kalturaPlaylistId, context)
.flatMap(new Func1<String[], Observable<?>>() {
@Override
public Observable<?> call(String[] videoIdList) {
return getKalturaVideoListObservable(context, videoIdList)
.doOnNext(kalturaVideo -> {
subscriber.onNext(kalturaVideo);
})
.doOnCompleted(() -> subscriber.onCompleted());
}
})
.subscribe();
}
});
}
Don't use an Observable in a Observable. Just transform the first one
public static Observable<KalturaVideo> getVideoList(Context context, String kalturaPlaylistId){
return getKalturaPlaylistContentObservable(kalturaPlaylistId, context).flatMap((String[] videoIdList) -> getKalturaVideoListObservable(context, videoIdList));
}
Complex code
Observable<String[]> targetIdList = Observable.just(targetList)
.map((List<KalturaVideo> kalturaVideos) -> {
if(kalturaVideos == null || kalturaVideos.isEmpty()){
return new String[]{""};
}
String[] result = new String[kalturaVideos.size()];
int index = 0;
for (KalturaVideo item : kalturaVideos) {
result[index] = item.getId();
}
return result;
});
You try to rewrite code that Rx can natively already do.
Observable<String[]> targetIdList = Observable.just(targetList)
.flatMapIterable(videos -> videos)
.map(video -> video.getId())
.toList()
.map(l -> l.toArray(new String[]));
Upvotes: 2
Related Questions
- RxJava - Passing Observable as argument to method
- RXjava implement an observable for an object update
- Update and retain existing data with RxJava
- How to dynamically update an RX Observable?
- RxJava Combining Observables
- RxJava performing operation on a list and returning an observable
- RxJava Observable, emit on demand
- Update single list item RXJava
- How to properly convert Listeners to Reactive (Observables) using RxJava?
- How to refresh observable in RxJava?