CODEWITHSUNDEEP
phpcakephppackagecomposer-php
Angyo
Angyo

Reputation: 83

Composer autoload file not work if set in repositories

i wrote the followings

"repositories": [{
  "type": "package",
  "package": {
    "name": "rysas/ffxiv-lodestone-php-api",
    "version": "dev-master",
    "source": {
      "url": "git://github.com/rysas/Final-Fantasy-XIV-Lodestone-PHP-API.git",
      "type": "git",
      "reference": "origin/master"
    },
    "autoload": {
      "files": [
        "vendor/rysas/ffxiv-lodestone-php-api/ffxiv-lodestone-api.php"
      ]
    }
  }
}]

After doing a composer update, my library isn't loaded, everything works fine if i do the following

"repositories": [{
  "type": "package",
  "package": {
    "name": "rysas/ffxiv-lodestone-php-api",
    "version": "dev-master",
    "source": {
      "url": "git://github.com/rysas/Final-Fantasy-XIV-Lodestone-PHP-API.git",
      "type": "git",
      "reference": "origin/master"
    }
  }
}],
"autoload": {
    "psr-4": {
    "App\\": "src"
  },
  "files": [
    "vendor/rysas/ffxiv-lodestone-php-api/ffxiv-lodestone-api.php"
  ]
}

Do i really need to declare the autoloader ouside of the declaration of my package ?

Upvotes: 0

Views: 1286

Answers (1)

Sven
Sven

Reputation: 70913

When you add package information as "type=package", you have to do that from the perspective of that package.

And the autoloading rules say that autoloading must be defined relative from the PACKAGE ROOT. The package root is the directory that gets placed at "vendor/vendorname/packagename/", i.e. you must not add either the directory "vendor", "rysas" and "ffxiv-lodestone-php-api" to the autoload definition path.

Additionally, you should not use the "files" autoloader if the code that needs to get autoloaded is in fact a PHP class. Use the classmap autoloader for that (you can point it at distinct files as well as directories). The difference: Classmap autoloading takes place only if the class is needed. Files autoloading isn't really automatic - the files is ALWAYS executed when you require "vendor/autoload.php".

Files autoloading is meant to add global functions outside of classes because PHP cannot autoload them. The better solution for such code would be to put them into a class as a static function - this can be autoloaded. It should be seen as a workaround for old legacy code to make it usable with Composer.

Upvotes: 2

Related Questions