CODEWITHSUNDEEP
c#asp.net-web-apidatacontractserializer
ggtffg
ggtffg

Reputation: 323

WebApi Controller model serialization issue

I'm facing little stranger issue with Web API controller. I have a collection which is being passed in an action of api controller. Object being used is collection is having 4 properties.

My action is able to accept collection parameter when it's properties are in specific order. See below :- 

    [HttpPost]
    public ForexRates UpdateRates([FromBody] Rates rates)
    {
        // TODO: Obviously code :) 
        return rates;
    }

This code is being place in API controller & calling from Postman. See below:- 

<rates>
  <rate> 
   <id>fefef</id>
    <rate>35353.333</rate>
    <series>dfefge</series>
    <series-order>sfefefef</series-order>  
</rate></rates>

If I change the order of the properties I started getting null value in my action. Can some one please explain this :)

Models 

public class Rate
{
    public string Id { get; set; }
    public string Date { get; set; }
    public double Rate { get; set; }
}

public class Rates : Collection<ForexRate>
{
}

Upvotes: 0

Views: 782

Answers (3)

Theo
Theo

Reputation: 1

The issue has to do with the DataContractSerializer which expects the elements to occur in a specific order (alphabetical with some consideration given to inheritance). That's the default serializer used when creating a Web API project.

You can override this and specify a different serializer during API Configuration like this:

GlobalConfiguration.Configuration.Formatters.XmlFormatter
  .SetSerializer<SomeType>(new XmlSerializer(typeof(SomeType)));

Upvotes: 0

fdomn-m
fdomn-m

Reputation: 28611

The default binder can have issues when the same name is used in different places during binding.

In your case you've got Rate.Rate - both class name and property name. Try changing your class to (and corresponding xml for the post) :

public class Rate
{
    public string Id { get; set; }
    public string Date { get; set; }
    public double Value { get; set; }
}

and then try changing the order.

While I don't have a definitive reason why it works in one order and not another, it's likely that when it gets to the Rate(double) value it tries to create a new Rate(object) but doesn't have the correct properties (as its just a double).

A more complicated solution would be to write a specific model binder for the Rate object.

Upvotes: 0

now he who must not be named.
now he who must not be named.

Reputation: 9398

You will need to control the order with which your XML is serialized. Use XmlElementAttribute and specify the Order.

There is a similar question here

FYI, I suppose there is no way for you to change the order of the properties, while you supply from PostMan to your WebApi service. You will need to follow the exact order.

If you don't wanna do that, then pass this Xml as a string parameter and then parse it inside a method.

Upvotes: 1

Related Questions