CODEWITHSUNDEEP
google-app-engine
user365918
user365918

Reputation: 131

Google App Engine - Delete until count() <= 0

What is the difference between these 2 pieces of code?

query=Location.all(keys_only=True)
while query.count()>0:
  db.delete(query.fetch(5))

# --

while True:
  query=Location.all(keys_only=True)
  if not query.count():
    break
  db.delete(query.fetch(5))

They both work.

Upvotes: 2

Views: 295

Answers (4)

Nick Johnson
Nick Johnson

Reputation: 101149

Here's a solution that's neater, but you may or may not consider to be a hack:

q = Location.all(keys_only=True)
for batch in iter(lambda: q.fetch(500), []):
  db.delete(batch)

One gotcha, however, is that as you delete more and more, the backend is forced to skip over the 'tombstoned' entities to find the next ones that aren't deleted. Here's a more efficient solution that uses cursors:

q = Location.all(keys_only=True)
results = q.fetch(500)
while results:
  db.delete(results)
  q = Location.all(keys_only=True).with_cursor(q.cursor())
  results = q.fetch(500)

Upvotes: 2

David Underhill
David Underhill

Reputation: 16253

Logically, these two pieces of code perform the same exact thing - they delete every Location entity, 5 at a time.

The first piece of code is better both in terms of style and (slightly) in terms of performance. (The query itself does not need to be rebuilt in each loop).

However, this code is not as efficient as it could be. It has several problems:

  1. You use count() but do not need to. It would be more efficient to simply fetch the entities, and then test the results to see if you got any.

  2. You are making more round-trips to the datastore than you need to. Each count(), fetch(), and delete() call must go the datastore and back. These round-trips are slow, so you should try to minimize them. You can do this by fetching more entities in each loop.

Example:

q = Location.all(keys_only=True)
results = q.fetch(500)
while results:
    db.delete(results)
    results = q.fetch(500)

Edit: Have a look at Nick's answer below - he explains why this code's performance can be improved even more by using query cursors.

Upvotes: 6

user365918
user365918

Reputation: 131

It's too bad you can't do this in python.

query=Location.all(keys_only=True)
while locations=query.fetch(5):
  db.delete(locations)

Like in the other P language 

while(@row=$sth->fetchrow_array){
  do_something();
}

Upvotes: 0

Femaref
Femaref

Reputation: 61467

In the second one, query will be assigned/updated in every loop. I don't know if this is needed with the logic behind it (I don't use google app engine). To replicate this behaviour, the first one would have to look like this:

query=Location.all(keys_only=True)
while query.count()>0:
  db.delete(query.fetch(5))
  query=Location.all(keys_only=True)

In my oppinion, the first style is way more readable than the second one.

Upvotes: 0

Related Questions