CODEWITHSUNDEEP
javaswingbufferedimage
Adam Wechter
Adam Wechter

Reputation: 41

Writing Jpanel to Buffered Image stack overflow

I'm trying to write a JPanel Picture to a BufferedImage (later converted to Rendered Image). I am getting a stack overflow error in the AWT-EventQueue-0 thread for some reason and am not sure if there is a reason I have overlooked.

The code in question: 

public BufferedImage createImage() {
    int w = getWidth();
    int h = getHeight();
    BufferedImage bi = new BufferedImage(w, h, BufferedImage.TYPE_INT_RGB);
    cp.paint(bi.getGraphics());

    //debug script
    File outputfile = new File("image"+index+".jpg");
    try {
        ImageIO.write(bi, "jpg", outputfile);
    } catch (IOException e) {
        // TODO Auto-generated catch block
        e.printStackTrace();
    }
    index++;


    return bi;
}

The JPanel paintComponent

@Override
protected void paintComponent(Graphics g) {

    super.paintComponent(g);
    r = new Random(System.nanoTime());
    int maxSize = 100;
    int randX = r.nextInt(getWidth());
    int randY = r.nextInt(getHeight());
    int randWidth = r.nextInt(maxSize);
    int randHeight = r.nextInt(maxSize);
    Color color = new Color(r.nextInt(256), r.nextInt(256), r.nextInt(256));
    Graphics2D g2d = (Graphics2D) g;

    ovals.add(new MyCircles(randX, randY, randWidth, randHeight, color));   
    for (MyCircles c : ovals) {
            c.paint(g2d);
    }
    g2d.setColor(getForeground());


    repaint();

    double current = ImageComparator.calcDistance((RenderedImage)createImage());

    //debugging script
    System.out.println("Current: " + current);
    System.out.println("Previous" + previous);


    if(current > previous) {
        ovals.remove(ovals.size()-1);
    }
    else {
        previous = current;
    }


}

Any insight as to how to amend this issue would be greatly appreciated!

Upvotes: 0

Views: 51

Answers (3)

Soley
Soley

Reputation: 1766

Of course you have infinite loop there:

here is how you call your methods:

createImage()
 |__paint()
    |__createImage() // again in ImageComparator.calcDistance line
       |__paint()
           |__createImage() // again in ImageComparator.calcDistance line
              |__paint()
                 |__createImage() // again in ImageComparator.calcDistance line
                   |__paint()
                        TOY STORY 1 (Buzz) : to the infinite and beyond it :)

You never stop this cycle.

I suggest that you need to get the images and then compare them outsize of your paint. Let the paint just paint the image and do the comparison outside of it.

Upvotes: 0

camickr
camickr

Reputation: 324078

Not directly related to your problem but, you should never use the Random class in the painting method. Every time you call the method the painting will change, so the image you create and save will not be the same as the image on the panel.

Also, you should not be adding ovals in the paint method for the same reason give above.

You need to create an addOval(...) method that will set the random color of the Oval and add the oval to the List. The painting code will just iterate through the List and paint the Oval.

You also should NOT be removing ovals in the painting code. Painting code is for painting only, not manipulating the objects painted.

You can also try the Screen Image class which is basically a more flexible version of your image creation code.

Upvotes: 2

Reimeus
Reimeus

Reputation: 159754

Remove the the call to repaint in paintComponent which causes that method to be called ad infinitum

Upvotes: 4

Related Questions