CODEWITHSUNDEEP
javascriptregex
Rohan
Rohan

Reputation: 3795

Javascript split with RegEx

I just asked a question about Regex, and received a great answer: JavaScript Split without losing character

Now, I have another question.

My current Regex looks like this:

var split = text.split(/(?=\w*\d*\d:\d\d)/);

Basically, I'm trying to split using the timestamps (eg - 9:30 or 10:30, the difference between them is the extra digit in the latter). How do I go about this?

Currently, if I have these two:

9:30 pm
The user did action A.

10:30 pm
Welcome, user John Doe.

The splits are :

9:30 pm
The user did action A.
----
1
----
0:30 pm
Welcome, user John Doe.

How do I add an optional check for the first character in the timestamp?

Thanks!

Upvotes: 1

Views: 1316

Answers (3)

robertpateii
robertpateii

Reputation: 159

I'm not clear on what you're trying to do to the text, but I do have a regex that hopefully can help match the times only.

\d{1,2}:\d{1,2} (am|pm)

The problem with your regex and andy's regex is that the * is greedy. It means zero or more matches, as many times as possible. Using {min,max} with the exact numbers you need will be more accurate and avoid the greedy *.

edit: Andy's does in fact work on that site he linked. And the * doesn't seem to be greedy. Does either pattern work for you?

Upvotes: 1

Andy E
Andy E

Reputation: 344527

See my answer to your other question, I fixed this problem in the regex by adding a word boundary:

var split = journals.split(/\s*(?=\b\d+:)/);

Updated it with \s* to strip out any unnecessary whitespace (but not the line breaks) too. Result:

["9:30 pm    
The user did action A.", "10:30 pm  
Welcome, user John Doe.", "11:30 am
Messaged user John Doe"]

Upvotes: 1

Andy
Andy

Reputation: 14184

var split = text.split(/(?=\w*[\d]{1,2}:[\d]{2})/);

RegexPal is helpful for these tasks.

Upvotes: 1

Related Questions