CODEWITHSUNDEEP
signalr
megusta
megusta

Reputation: 134

Best practice to implement sending message to custom groups in SignalR

I am developing a real time multiplayer game using SignalR. The message delivery logic is not very simple which I could not handle it by using Groups.

For example, one message will be delivered to users with some custom property equals to some dynamic value. It means the target audiance can not be handled by

Clients.All
Clients.AllExcept

I have a mapping class something like this:

public class Player
{
  public dynamic Client { get; set; }

  public string ConnectionId { get; set; }

  public string Name { get; set; }
}

Somehow I do detect all my audiences in a List object.

What is the best way to send message to everyone in the list? Enumerating through list and calling 

        foreach (var loopPlayer in players)
        {
            player.Client.sendMessage(message);
        }

Or 

        List<string> ids = new List<string>();
        foreach (var loopPlayer in players)
        {
            ids.Add(item.ConnectionId.ToString());
        }

        Clients.Clients(ids).sendMessage(message);

My concern about the first one is, it will serialize the message every time. About the second one, I don't know how it is working behind the scene.

The both approach is working but I am concerning about performance and trying to find the best practice. Or which any other approach I might use?

Upvotes: 1

Views: 436

Answers (1)

Michal Lev&#253;
Michal Lev&#253;

Reputation: 37953

As you said, enumerating over list of clients serialize message each and every time (and store those serialized messages in internal buffers etc etc). If message is same, this is unnecessary CPU\memory overhead. Clients.Clients(ids) serializes message only once so performance vise, its definitely way to go.

The message delivery logic is not very simple which I could not handle it by using Groups. For example, one message will be delivered to users with some custom property equals to some dynamic value.

Groups work in scaleout scenario out of the box which is huge benefit if you ever find yourself in need to scaleout. So maybe try to find some way to simplify "group assigment logic" even at cost of delivering some messages to more clients and doing "filtering" client side...

Upvotes: 1

Related Questions