issue with friend functions in c++

Question

I have defined the following class with some friend functions in an h file:

#include <iostream>
#include <math.h>

namespace mtm {
static bool compareIsBigger(double a, double b) {
    const double EPSILON = 1e-10;
    return fabs(a - b) < EPSILON ? false : a > b;
}

static bool areSame(double a, double b) {
   const double EPSILON = 1e-10;
   return fabs(a - b) < EPSILON;
}
class Security  {
private:
    char* name;
    double stockValue;
    int stockAmount;
    double* quarterAnalyse;
    void operator =(const Security&) = delete;
    static bool nameIsInCaps(const char* name);
public:
    //// *other functions not relevant*
    friend bool operator==(const Security& s1, const Security& s2);
    friend bool operator!=(const Security& s1, const Security& s2);
    friend bool operator>=(const Security& s1, const Security& s2);
    friend bool operator<(const Security& s1, const Security& s2);
    friend bool operator>(const Security& s1, const Security& s2);
    friend bool operator<=(const Security& s1, const Security& s2);
    friend bool operator>=(const Security& s1, const Security& s2);
};
}

I have then implemented them in a c file (that includes the header of course):

#include "Security.h"
#include "exception.h"
#include <iostream>
#include <cstring>

using namespace mtm;

bool operator==(const Security &s1, const Security &s2) {
    if (areSame(s1.stockValue, s2.stockValue) && s1.stockAmount == s2.stockAmount
        && !strcmp(s1.name, s2.name))
        return true;
    return false;
}

bool operator!=(const Security &s1, const Security &s2) {
    if (!(s1 == s2))
        return true;
    return false;
}

bool operator<(const Security &s1, const Security &s2) {
    if (compareIsBigger(s1.stockValue, s2.stockValue))
        return true;
    if (areSame(s1.stockValue, s2.stockValue)) {
        if (s2.stockAmount > s1.stockAmount)
            return true;
        if (s2.stockAmount == s1.stockAmount) {
            if (strcmp(s2.name, s1.name) > 0)
                return true;
        }
    }
    return false;
}


bool operator>(const Security &s1, const Security &s2) {
    if (!(s1 < s2) && s1 != s2)
        return true;
    return false;
}


bool operator<=(const Security &s1, const Security &s2) {
    if (!(s1 > s2))
        return true;
    return false;
}

bool operator>=(const Security &s1, const Security &s2) {
    if (!(s1 < s2))
        return true;
    return false;
}

However, for each of these implementations, the compiler complains that these functions don't have access to private parts!

Why is that? I have declared them as friend functions!
I am using eclipse if it is of any matter.

These are the compilation results regarding this problem:

Description Resource    Path    Location    Type
'char* mtm::Security::name' is private  Security.h  /MTM_HW4    line 32 C/C++ Problem
'double mtm::Security::stockValue' is private   Security.h  /MTM_HW4    line 33 C/C++ Problem
'int mtm::Security::stockAmount' is private Security.h  /MTM_HW4    line 34 C/C++ Problem
ambiguous overload for 'operator!=' (operand types are 'const mtm::Security' and 'const mtm::Security') Security.cpp    /MTM_HW4    line 183    C/C++ Problem
ambiguous overload for 'operator' (operand types are 'const mtm::Security' and 'const mtm::Security')  Security.cpp    /MTM_HW4    line 190    C/C++ Problem
within this context Security.cpp    /MTM_HW4    line 155    C/C++ Problem
within this context Security.cpp    /MTM_HW4    line 156    C/C++ Problem
within this context Security.cpp    /MTM_HW4    line 168    C/C++ Problem
within this context Security.cpp    /MTM_HW4    line 170    C/C++ Problem
within this context Security.cpp    /MTM_HW4    line 171    C/C++ Problem
within this context Security.cpp    /MTM_HW4    line 173    C/C++ Problem
within this context Security.cpp    /MTM_HW4    line 174    C/C++ Problem
bool mtm::operator!=(const mtm::Security&, const mtm::Security&)    Security.h  /MTM_HW4    line 60 C/C++ Problem
bool mtm::operator(const mtm::Security&, const mtm::Security&) Security.h  /MTM_HW4    line 63 C/C++ Problem
bool operator!=(const mtm::Security&, const mtm::Security&) Security.cpp    /MTM_HW4    line 161    C/C++ Problem
bool operator(const mtm::Security&, const mtm::Security&)  Security.cpp    /MTM_HW4    line 182    C/C++ Problem
candidates are: Security.cpp    /MTM_HW4    line 162    C/C++ Problem
candidates are: Security.cpp    /MTM_HW4    line 183    C/C++ Problem
candidates are: Security.cpp    /MTM_HW4    line 190    C/C++ Problem
candidates are: Security.cpp    /MTM_HW4    line 196    C/C++ Problem

Answer 1

You need to declare the operator overloads outside of the class in the header file as well.