CODEWITHSUNDEEP
unit-testinggrails
Pablo Pazos
Pablo Pazos

Reputation: 3216

Grails 2.4.4 controller test on save() return empty model

I have a test for a PersonController, it just executes save() with no params, so an invalid person is created. It should return the invalid person in the model and show the create view. But the model is empty.

The test:

import org.junit.*
import grails.test.mixin.*

@TestFor(PersonController)
@Mock(Person)
class PersonControllerTests {
   ...
   void testSave() {
       controller.save() // creates invalid person, redirects to create
       assert model.personInstance != null
       assert view == '/person/create'

       response.reset()

       populateValidParams(params)
       controller.save()

       assert response.redirectedUrl == '/person/show/1'
       assert controller.flash.message != null
       assert Person.count() == 1
   }
   ...
}

The controller:

class PersonController {

   ...
    def save() {
        def personInstance = new Person(params)
        if (!personInstance.save(flush: true)) {
            render(view: "create", model: [personInstance: personInstance])
            return
        }

        flash.message = message(code: 'default.created.message', args: [message(code: 'person.label', default: 'Person'), personInstance.id])
        redirect(action: "show", id: personInstance.id)
    }
   ...
}

The output:

junit.framework.AssertionFailedError: Assertion failed: 

assert model.personInstance != null
       |     |              |
       [:]   null           false

    at demographic.PersonControllerTests.testSave(PersonControllerTests.groovy:43)

How can I get the right model?

Is this the expected behavior or is this a Grails bug?

Upvotes: 0

Views: 284

Answers (1)

Jon Burgess
Jon Burgess

Reputation: 2115

The test is failing (rightly so, I believe) because of the HTTP method restrictions in the controller, i.e. the line:

static allowedMethods = [save: "POST", update: "POST", delete: "POST"]

Set the HTTP method in the test, and the test passes:

void testSave() {
    controller.request.method = 'POST'
    controller.save() // creates invalid person, redirects to create
    ...

Upvotes: 1

Related Questions