ObservableCollection not update my UI

Question

This is my Model:

public class WiresharkFile : INotifyPropertyChanged
{
    public event PropertyChangedEventHandler PropertyChanged;

    virtual public void NotifyPropertyChange(string propertyName)
    {
        var handler = PropertyChanged;
        if (handler != null)
            handler(this, new PropertyChangedEventArgs(propertyName));
    }

   private string _file; // file path
   private string _packets; // how many packet in file
   private string _sentPackets; // how many packet sent
   private string _progress; // percentage (_sentPackets/_packets) * 100

   public int Progress
   {
       get { return _progress; }
       set
       {
           _progress = value;
           NotifyPropertyChange("Progress");
       }
   }

   public void Transmit(WireshrkFile)
   {
         // here i am send the packets
   }

    public event PropertyChangedEventHandler PropertyChanged;

    virtual public void NotifyPropertyChange(string propertyName)
    {
        var handler = PropertyChanged;
        if (handler != null)
            handler(this, new PropertyChangedEventArgs(propertyName));
    }
}

My model collection:

public ObservableCollection files{ get; set; }

My ListView:

I can see that my collection properties changing but mu UI not.

Olaru Mircea · Accepted Answer

Note: Pay attention here: ItemsSource="{Binding WiresharkFile}"

Change this to ItemsSource="{Binding files}"

I've prepared a small sample:

Window x:Class="ProgressBarChangedStack.MainWindow"
    xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
    Title="MainWindow" Height="350" Width="525">

Simple View, you have a ProgressBar there with its Value bound to a property from the Model.

This is the Model:

public class Model : INotifyPropertyChanged
{
    private int _Progress;

    public int Progress
    {
        get { return _Progress; }
        set
        {
            _Progress = value;
            PropertyChanged(this, new PropertyChangedEventArgs("Progress"));
        }
    }
    public event PropertyChangedEventHandler PropertyChanged = delegate { };
}

I think there is nothing to explain here, you have the same approach.

And here is my testing code:

 public partial class MainWindow : Window
{
    public ObservableCollection files { get; set; }

    public MainWindow()
    {
        InitializeComponent();
        files = new ObservableCollection();
        files.Add(new Model() { Progress = 20 });
        files.Add(new Model() { Progress = 30 });
        files.Add(new Model() { Progress = 40 });
        this.DataContext = this;
    }

    private void btnProgressComplete_Click(object sender, RoutedEventArgs e)
    {
        foreach (var file in files)
        {
            file.Progress = 100;
        }
    }
}

So, when i click the Button, all the ProgressBars will be complete.

I see you don't have INPC implemented for these properties:

  private string _file; // file path
  private string _packets; // how many packet in file
  private string _sentPackets; // how many packet sent
  private string _progress; // percentage (_sentPackets/_packets) * 100

With their actual form, the View will not be inform when changes occur.

ObservableCollection not update my UI

Answers (1)

Related Questions