RecyclerView OnBindViewHolder unexpected

Question

onBindViewHolder is unexpectedly called on the first position and then the last position after data is bound to the view. This created problems because when I tried adding items to the list, ImageViews (like and unlike) of the last item were being swapped/recycled with the first item in the list. How can I prevent this from happening?

Recycler Adapter Code:

public class RecyclerAdapterForOpinion extends RecyclerView.Adapter<RecyclerAdapterForOpinion.OpinionViewHolder> {

private LayoutInflater inflater;
private List<ParseObject> opinionList;
private String currentUsername = Application.currentUser.getString("Name");

public RecyclerAdapterForOpinion(Context context, List<ParseObject> opinionList) {
    inflater = LayoutInflater.from(context);
    this.opinionList = opinionList;
}

@Override
public OpinionViewHolder onCreateViewHolder(ViewGroup viewGroup, int viewType) {

    Log.d("RecyclerAdapter", "OnCreateViewHolder called");
    View itemView = inflater.inflate(R.layout.item_view_poll, viewGroup, false);
    return new OpinionViewHolder(itemView);
}

@Override
public void onBindViewHolder(final OpinionViewHolder opinionViewHolder, final int position) {

    Log.d("RecyclerAdapter", "OnBindViewHolder called for position: " + position);
    ParseObject current = opinionList.get(position);
    opinionViewHolder.entry.setText(current.getString("entry"));
    opinionViewHolder.rationale.setText(current.getString("rationale"));
    opinionViewHolder.priority.setText("" + current.getInt("priority"));

    List<String> userLikes = (List<String>) current.get("userLike");
    List<String> userUnlikes = (List<String>) current.get("userUnlike");

    if (userLikes != null) {
        if(userLikes.size() != 0){
            if (userLikes.contains(currentUsername)) {
                    opinionViewHolder.like.setChecked(true);
            }
        }
    }
    if (userUnlikes != null) {
        if(userUnlikes.size() != 0) {
            if (userUnlikes.contains(currentUsername)) {
                    opinionViewHolder.unlike.setChecked(true);
            }
        }
    }  
}

@Override
public int getItemCount() {
    return opinionList.size();
}

public void addItem(ParseObject opinion) {
    opinionList.add(opinion);
    notifyDataSetChanged();
}

public class OpinionViewHolder extends RecyclerView.ViewHolder {

    TextView entry;
    TextView rationale;
    TextView priority;
    CheckBox like, unlike;
    ImageButton trash;

    public OpinionViewHolder(View itemView) {
        super(itemView);
        entry = (TextView) itemView.findViewById(R.id.opinionEntry);
        like = (CheckBox) itemView.findViewById(R.id.opinionLike);
        unlike = (CheckBox) itemView.findViewById(R.id.opinionUnlike);
        rationale = (TextView) itemView.findViewById(R.id.opinionRationale);
        priority = (TextView) itemView.findViewById(R.id.opinionPriority);
        trash = (ImageButton) itemView.findViewById(R.id.trash);


        like.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {
                ParseObject current = opinionList.get(getAdapterPosition());
                CheckBox check = (CheckBox) v;
                if (check.isChecked()) {
                    Application.likeOpinion(current);
                } else {
                    Application.removeLike(current);
                }
                priority.setText("" + current.getInt("priority"));
            }
        });

        unlike.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {
                ParseObject current = opinionList.get(getAdapterPosition());
                CheckBox check = (CheckBox) v;
                if (check.isChecked()) {
                    Application.unlikeOpinion(current);
                } else {
                    Application.removeUnlike(current);
                }
                priority.setText("" + current.getInt("priority"));
            }
        });
    }
 }

}

Logcat Output:

06-30 19:47:01.499    8579-8579/com.nishantjain.dime.dime D/RecyclerAdapter﹕ OnCreateViewHolder called

06-30 19:47:01.519    8579-8579/com.nishantjain.dime.dime D/RecyclerAdapter﹕ OnBindViewHolder called for position: 0

06-30 19:47:01.529    8579-8579/com.nishantjain.dime.dime D/RecyclerAdapter﹕ OnCreateViewHolder called

06-30 19:47:01.539    8579-8579/com.nishantjain.dime.dime D/RecyclerAdapter﹕ OnBindViewHolder called for position: 1

06-30 19:47:01.539    8579-8579/com.nishantjain.dime.dime D/RecyclerAdapter﹕ OnCreateViewHolder called

06-30 19:47:01.549    8579-8579/com.nishantjain.dime.dime D/RecyclerAdapter﹕ OnBindViewHolder called for position: 2

06-30 19:47:01.549    8579-8579/com.nishantjain.dime.dime D/RecyclerAdapter﹕ OnBindViewHolder called for position: 0

06-30 19:47:01.549    8579-8579/com.nishantjain.dime.dime D/RecyclerAdapter﹕ OnBindViewHolder called for position: 2

Answer 1

In adapter always use else with every if statement. Specially when dealing with views.

if (userLikes != null && userLikes.size() != 0 && userLikes.contains(currentUsername)) {
    opinionViewHolder.like.setChecked(true);
}else{
   opinionViewHolder.like.setChecked(false);
}

Do same for other one. Hope it will solve your problem.