CODEWITHSUNDEEP
javacollectionshashmapcompare
Dave
Dave

Reputation: 1502

Order HashMap by value in Java doesn't work

I have this object:

public class Customer {

    private String id;
    private String name;
    private String cf;
    private String pi;
    private String telephone;
    private String email;
    private String website;
    private String sector;
    private String address;

    //constructor and getter, setter method

}

and a Map of Customer into main:

Map<String, Customer> customerMap = new HashMap<>();
customerMap.put("1", customer1);
customerMap.put("2", customer2);
...

sortMapByName(customerMap);

I want to order it by name attribute.

I use the solution at this link: How to sort a Map in Java

Code:

public void sortMapByName(Map<String, Customer> unsortMap) {

    // Convert Map to List
    List<Map.Entry<String, Customer>> list = new LinkedList<>(unsortMap.entrySet());

    // Sort list with comparator, to compare the Map values
    Collections.sort(list, new Comparator<Map.Entry<String, Customer>>() {

        @Override
        public int compare(Map.Entry<String, Customer> o1, Map.Entry<String, Customer> o2) {
            return (o1.getValue().getName()).compareTo(o2.getValue().getName());
        }
    });

    // Convert sorted map back to a Map
    listCustomer = new LinkedHashMap<>();
    for (Map.Entry<String, Customer> entry : list) {
        listCustomer.put(entry.getKey(), entry.getValue());
    }

}

it doesn't work, why?

UPDATE

Please, try it.

Customer.java

public class Customer {

private String id;
private String name;
private String cf;
private String pi;
private String telephone;
private String email;
private String website;
private String sector;
private String address;

public Customer() {
}

public Customer(String id, String name, String cf, String pi, String telephone, String email, String website, String sector, String address) {
    this.id = id;
    this.name = name;
    this.cf = cf;
    this.pi = pi;
    this.telephone = telephone;
    this.email = email;
    this.website = website;
    this.sector = sector;
    this.address = address;
}

public String getId() {
    return id;
}

public void setId(String id) {
    this.id = id;
}

public String getName() {
    return name;
}

public void setName(String name) {
    this.name = name;
}

public String getCf() {
    return cf;
}

public void setCf(String cf) {
    this.cf = cf;
}

public String getPi() {
    return pi;
}

public void setPi(String pi) {
    this.pi = pi;
}

public String getTelephone() {
    return telephone;
}

public void setTelephone(String telephone) {
    this.telephone = telephone;
}

public String getEmail() {
    return email;
}

public void setEmail(String email) {
    this.email = email;
}

public String getWebsite() {
    return website;
}

public void setWebsite(String website) {
    this.website = website;
}

public String getSector() {
    return sector;
}

public void setSector(String sector) {
    this.sector = sector;
}

public String getAddress() {
    return address;
}

public void setAddress(String address) {
    this.address = address;
}

Main.java

public class Main { 

public static void main(String[] args) {

    Map<String, Customer> unsortedMap = new HashMap<>();

    Customer one = new Customer("1", "B", "bbb", "1234", "bbb", "gmail.com", "none", "student", "Italy");
    Customer two = new Customer("2", "C", "ccc", "1234", "ccc", "gmail.com", "none", "student", "Italy");
    Customer three = new Customer("3", "A", "aaa", "1234", "aaa", "gmail.com", "none", "student", "Italy");

    unsortedMap.put("1", one);
    unsortedMap.put("2", two);
    unsortedMap.put("3", three);

    System.out.print("Before: \n"+unsortedMap);

    Map<String, Customer> sortedMap = sortMapByName(unsortedMap);

    System.out.print("\n\nAfter: \n"+sortedMap);
}

public static Map<String, Customer> sortMapByName(Map<String, Customer> unsortMap) {

    // Convert Map to List
    List<Map.Entry<String, Customer>> list = new LinkedList<>(unsortMap.entrySet());

    // Sort list with comparator, to compare the Map values
    Collections.sort(list, new Comparator<Map.Entry<String, Customer>>() {

        @Override
        public int compare(Map.Entry<String, Customer> o1, Map.Entry<String, Customer> o2) {
            return (o1.getValue().getName()).compareTo(o2.getValue().getName());
        }
    });

    // Convert sorted map back to a Map
    Map<String, Customer> sortedMap = new LinkedHashMap<>();
    for (Iterator<Map.Entry<String, Customer>> it = list.iterator(); it.hasNext();) {
        Map.Entry<String, Customer> entry = it.next();
        sortedMap.put(entry.getKey(), entry.getValue());
    }

    return sortedMap;

}

}

Upvotes: 0

Views: 155

Answers (1)

M A
M A

Reputation: 72884

You need to use the sorted map in the method. Change the type from void to Map<String, Customer and add return listCustomer; at the end. The original map is simply preserved unchanged in your current code.

public Map<String, Customer> sortMapByName(Map<String, Customer> unsortMap) {

   ...
   return listCustomer;
}

If, for some reason, listCustomer is a class member, make sure you use that instead of the original unsorted one.

UPDATE: When printing the map, you can loop over the map entries:

for (Iterator<String> iterator = sortedMap.keySet().iterator(); iterator.hasNext();) {
    Customer cust = sortedMap.get(iterator.next());
    System.out.println(cust);   
}

You'd also need to override the toString() method in Customer to print something useful, something like:

@Override
public String toString() {
    return "Customer [id=" + id + ", name=" + name + ", cf=" + cf + ", pi="
            + pi + ", telephone=" + telephone + ", email=" + email
            + ", website=" + website + ", sector=" + sector + ", address="
            + address + "]";
}

Upvotes: 2

Related Questions