AngeL iFe
Reputation: 11
Generating Random Color
I couldn't get my fishes filled up with random color, but whatever I did, it didn't change my fish. Here is the code.
import java.awt.Color;
import java.util.Random;
import uwcse.graphics.*;
/**
* A fish in a graphics window
*/
public class Fish {
// The graphics window the fish belongs to
private GWindow window;
// The location of the fish
private int x;
private int y;
// Scale of the drawing of the fish
private double scale;
private Color color;
/**
* Draws a Fish in a graphics window
*
* @param x
* the x coordinate of the location of the fish
* @param y
* the y coordinate of the location of the fish
* @param scale
* the scale of the drawing of the fish
* @param window
* the graphics window the fish belongs to
*/
public Fish(int x, int y, double scale, GWindow window) {
// Initialize the instance fields
this.x = x;
this.y = y;
this.scale = scale;
this.window = window;
this.color = randomColor();
// Draw the fish
this.draw();
}
private Color randomColor(){
Random random = new Random();
int R = random.nextInt(256);
int G = random.nextInt(256);
int B = random.nextInt(256);
System.out.println(R + " " + B + " " + G);
return new Color(R,B,G);
}
/**
* Draws this fish
*/
private void draw() {
int Fsize = (int)(this.scale*15);
Oval O1 = new Oval(this.x - Fsize /3,
this.y - Fsize /7 ,
Fsize + 3*Fsize/3,
Fsize + Fsize/5,
Color.CYAN,true);
Triangle tail1 =new Triangle(this.x - Fsize,
this.y,
this.x - 2/Fsize,
this.y + Fsize/2,
this.x - Fsize,
this.y + Fsize,Color.CYAN,true);
Line eye1 = new Line(this.x + 12*Fsize/10,
this.y + 5*Fsize/10 ,
this.x + 12*Fsize/10,
this.y + 5* Fsize /10,
Color.BLACK);
Oval O2 = new Oval(this.x - 37*Fsize/5,
this.y+ 27*Fsize/5 ,
Fsize + 2*Fsize/3,
Fsize + Fsize/5,
Color.CYAN,true);
Line eye2 = new Line(
this.x - 35*Fsize/5,
this.y + 30*Fsize/5,
this.x - 35*Fsize/5,
this.y + 30*Fsize/5, Color.BLACK);
Triangle tail2 =new Triangle(this.x - Fsize*5 ,
this.y + 13*Fsize/2,
this.x - 10*Fsize/2,
this.y + 11*Fsize/2,
this.x - Fsize*6,
this.y + Fsize*6,Color.CYAN,true);
this.window.add(O1);
this.window.add(O2);
this.window.add(tail2);
this.window.add(tail1);
this.window.add(eye1);
this.window.add(eye2);
}
}
`
Upvotes: 1
Views: 865
Answers (2)
Blake Yarbrough
Reputation: 2316
As @Michelle said, you aren't actually using the randomColor() method or the value of this.color which is initialized with a value from randomColor() when defining the color of your fish parts in your draw() method. Try the below modification.
import java.awt.Color; import java.util.Random; import uwcse.graphics.*;
/** * A fish in a graphics window */
public class Fish {
// The graphics window the fish belongs to
private GWindow window;
// The location of the fish
private int x;
private int y;
// Scale of the drawing of the fish
private double scale;
private Color color;
/**
* Draws a Fish in a graphics window
*
* @param x
* the x coordinate of the location of the fish
* @param y
* the y coordinate of the location of the fish
* @param scale
* the scale of the drawing of the fish
* @param window
* the graphics window the fish belongs to
*/
public Fish(int x, int y, double scale, GWindow window) {
// Initialize the instance fields
this.x = x;
this.y = y;
this.scale = scale;
this.window = window;
this.color = randomColor();
// Draw the fish
this.draw();
}randomColor()
private Color randomColor(){
Random random = new Random();
int R = random.nextInt(256);
int G = random.nextInt(256);
int B = random.nextInt(256);
System.out.println(R + " " + B + " " + G);
return new Color(R,B,G);
}
/**
* Draws this fish
*/
private void draw() {
int Fsize = (int)(this.scale*15);
Oval O1 = new Oval(this.x - Fsize /3,
this.y - Fsize /7 ,
Fsize + 3*Fsize/3,
Fsize + Fsize/5,
randomColor(),true);
Triangle tail1 =new Triangle(this.x - Fsize,
this.y,
this.x - 2/Fsize,
this.y + Fsize/2,
this.x - Fsize,
this.y + Fsize,randomColor(),true);
Line eye1 = new Line(this.x + 12*Fsize/10,
this.y + 5*Fsize/10 ,
this.x + 12*Fsize/10,
this.y + 5* Fsize /10,
randomColor());
Oval O2 = new Oval(this.x - 37*Fsize/5,
this.y+ 27*Fsize/5 ,
Fsize + 2*Fsize/3,
Fsize + Fsize/5,
randomColor(),true);
Line eye2 = new Line(
this.x - 35*Fsize/5,
this.y + 30*Fsize/5,
this.x - 35*Fsize/5,
this.y + 30*Fsize/5, randomColor());
Triangle tail2 =new Triangle(this.x - Fsize*5 ,
this.y + 13*Fsize/2,
this.x - 10*Fsize/2,
this.y + 11*Fsize/2,
this.x - Fsize*6,
this.y + Fsize*6,randomColor(),true);
this.window.add(O1);
this.window.add(O2);
this.window.add(tail2);
this.window.add(tail1);
this.window.add(eye1);
this.window.add(eye2);
}
}
or if you want the whole fish to be the same color try something like the following modification
import java.awt.Color; import java.util.Random; import uwcse.graphics.*;
/** * A fish in a graphics window */
public class Fish {
// The graphics window the fish belongs to
private GWindow window;
// The location of the fish
private int x;
private int y;
// Scale of the drawing of the fish
private double scale;
private Color color;
/**
* Draws a Fish in a graphics window
*
* @param x
* the x coordinate of the location of the fish
* @param y
* the y coordinate of the location of the fish
* @param scale
* the scale of the drawing of the fish
* @param window
* the graphics window the fish belongs to
*/
public Fish(int x, int y, double scale, GWindow window) {
// Initialize the instance fields
this.x = x;
this.y = y;
this.scale = scale;
this.window = window;
this.color = randomColor();
// Draw the fish
this.draw();
}randomColor()
private Color randomColor(){
Random random = new Random();
int R = random.nextInt(256);
int G = random.nextInt(256);
int B = random.nextInt(256);
System.out.println(R + " " + B + " " + G);
return new Color(R,B,G);
}
/**
* Draws this fish
*/
private void draw() {
int Fsize = (int)(this.scale*15);
Oval O1 = new Oval(this.x - Fsize /3,
this.y - Fsize /7 ,
Fsize + 3*Fsize/3,
Fsize + Fsize/5,
this.color,true);
Triangle tail1 =new Triangle(this.x - Fsize,
this.y,
this.x - 2/Fsize,
this.y + Fsize/2,
this.x - Fsize,
this.y + Fsize,this.color,true);
Line eye1 = new Line(this.x + 12*Fsize/10,
this.y + 5*Fsize/10 ,
this.x + 12*Fsize/10,
this.y + 5* Fsize /10,
this.color);
Oval O2 = new Oval(this.x - 37*Fsize/5,
this.y+ 27*Fsize/5 ,
Fsize + 2*Fsize/3,
Fsize + Fsize/5,
this.color,true);
Line eye2 = new Line(
this.x - 35*Fsize/5,
this.y + 30*Fsize/5,
this.x - 35*Fsize/5,
this.y + 30*Fsize/5, this.color);
Triangle tail2 =new Triangle(this.x - Fsize*5 ,
this.y + 13*Fsize/2,
this.x - 10*Fsize/2,
this.y + 11*Fsize/2,
this.x - Fsize*6,
this.y + Fsize*6,this.color,true);
this.window.add(O1);
this.window.add(O2);
this.window.add(tail2);
this.window.add(tail1);
this.window.add(eye1);
this.window.add(eye2);
}
}
Upvotes: 1
Berrigan
Reputation: 438
You are using color constant variables. Instead of Color.CYAN use your random color
Upvotes: 3
Related Questions
- How do I generate a random color in a specific range?
- Java Random Color String
- Creating random colour in Java?
- How to generate random bright color?
- Random characters and random colors generator
- Randomize a color with a condition
- Random sequence of colors
- java generate random "light" color only
- How to apply random color?
- Setting a Random Color