CODEWITHSUNDEEP
python
The Nightman
The Nightman

Reputation: 5759

Improving the speed of a python script

I have an input file with containing a list of strings.

I am iterating through every fourth line starting on line two.

From each of these lines I make a new string from the first and last 6 characters and put this in an output file only if that new string is unique.

The code I wrote to do this works, but I am working with very large deep sequencing files, and has been running for a day and has not made much progress. So I'm looking for any suggestions to make this much faster if possible. Thanks.

def method():
    target = open(output_file, 'w')

    with open(input_file, 'r') as f:
        lineCharsList = []

        for line in f:
            #Make string from first and last 6 characters of a line
            lineChars = line[0:6]+line[145:151] 

            if not (lineChars in lineCharsList):
                lineCharsList.append(lineChars)

                target.write(lineChars + '\n') #If string is unique, write to output file

            for skip in range(3): #Used to step through four lines at a time
                try:
                    check = line    #Check for additional lines in file
                    next(f)
                except StopIteration:
                    break
    target.close()

Upvotes: 5

Views: 116

Answers (4)

Doug
Doug

Reputation: 3863

Try replacing

lineChars = line[0:6]+line[145:151]

with

lineChars = ''.join([line[0:6], line[145:151]])

as it can be more efficient, depending on the circumstances.

Upvotes: 1

lightalchemist
lightalchemist

Reputation: 10211

Besides using set as Oscar suggested, you can also use islice to skip lines rather than use a for loop.

As stated in this post, islice preprocesses the iterator in C, so it should be much faster than using a plain vanilla python for loop.

Upvotes: 2

dting
dting

Reputation: 39287

You can use https://docs.python.org/2/library/itertools.html#itertools.islice:

import itertools

def method():
    with open(input_file, 'r') as inf, open(output_file, 'w') as ouf:
        seen = set()
        for line in itertools.islice(inf, None, None, 4):
            s = line[:6]+line[-6:]
            if s not in seen:
                seen.add(s)
                ouf.write("{}\n".format(s))

Upvotes: 5

Óscar López
Óscar López

Reputation: 235984

Try defining lineCharsList as a set instead of a list:

lineCharsList = set()
...
lineCharsList.add(lineChars)

That'll improve the performance of the in operator. Also, if memory isn't a problem at all, you might want to accumulate all the output in a list and write it all at the end, instead of performing multiple write() operations.

Upvotes: 6

Related Questions