CODEWITHSUNDEEP
javascriptcross-browser
Adriana
Adriana

Reputation: 8614

javascript not working in chrome/opera/IE but firefox is excellent!

I've got this code, working only in firefox.

 <script type="text/javascript">
    function setVideo(url){
        url = url.replace("watch?v=","v/","i");
        var movie = document.getElementById('movie');
        movie.setAttribute('src',url+"&hl=en&fs=1&");
        var param = document.getElementById('paramm');
        param.setAttribute('value',url+"&hl=en&fs=1&");
    }
</script>

<object width="425" height="344">
            <param name="movie" id="paramm"></param>
            <param name="allowFullScreen" value="true"></param>
            <param name="allowscriptaccess" value="always"></param>
            <embed id="movie" type="application/x-shockwave-flash" allowscriptaccess="always" allowfullscreen="true" width="425" height="344" src=""></embed>
        </object>

<a href="#" onclick="setVideo('http://www.youtube.com/watch?v=3h1qQaRxY40')">example</a>

PLEASE help, I have no idea, it's such a simple script, why is it not working?? thanks

Upvotes: 0

Views: 981

Answers (4)

gblazex
gblazex

Reputation: 50109

Don't use setAttribute with value. It is known to cause problems.

function setVideo(url){
    url = url.replace("watch?v=","v/";
    var movie = document.getElementById('movie');
    movie.src = url+"&hl=en&fs=1&";
    var param = document.getElementById('paramm');
    param.value = url+"&hl=en&fs=1&";
}

Upvotes: 1

Pekka
Pekka

Reputation: 449485

You are trying to dynamically change the video source in an embed element. This is notoriously tricky and in fact needs a workaround for browsers other than Firefox.

This question seems to provide a solution: Dynamically change embedded video src in IE/Chrome (works in Firefox)

Upvotes: 6

David Radcliffe
David Radcliffe

Reputation: 1491

You should probably use something like swfobject (http://code.google.com/p/swfobject) to embed the ENTIRE flash object when the setVideo function is called - don't just change the url. IE and chrome probably don't recognize the change.

Upvotes: 2

ob1
ob1

Reputation: 1721

You didn't provide any error message, so it's hard to say what needs to be fixed ...

One thing I did notice is that you use non-standard syntax for the "replace" method.

See https://developer.mozilla.org/en/Core_JavaScript_1.5_Reference/Objects/String/replace for explanation and alternatives

Upvotes: 3

Related Questions