CODEWITHSUNDEEP
phpjsonstring
Donnie Darko
Donnie Darko

Reputation: 519

Error Converting JSON to array PHP

Hello So i have this call.

$preciobitcoin = curlCall('https://www.bitstamp.net/api/ticker/');

and i can perfectly get $preciobitcoin['last'].

but this one

$preciodolar = curlCall('https://s3.amazonaws.com/dolartoday/data.json');

return as a string instead of an array

this is the code of the function which is not working this is the code of the function which is not working

function curlCall($url, $params = null, $contentType = 'application/json', $options = array()) {
$curl = curl_init($url);
curl_setopt($curl, CURLOPT_FAILONERROR, true);
curl_setopt($curl, CURLOPT_FOLLOWLOCATION, true);
curl_setopt($curl, CURLOPT_RETURNTRANSFER, true);
curl_setopt($curl, CURLOPT_CONNECTTIMEOUT, 10);
curl_setopt($curl, CURLOPT_SSL_VERIFYHOST, false);
curl_setopt($curl, CURLOPT_SSL_VERIFYPEER, false);
curl_setopt($curl, CURLOPT_SSLVERSION, 4);

if (!is_null($params) && !is_null($options['key']) && !is_null($options['sig'])) {
    curl_setopt($curl, CURLOPT_POST, TRUE);
    curl_setopt($curl, CURLOPT_POSTFIELDS, $params);
    curl_setopt($curl, CURLOPT_HTTPHEADER, array('Content-Type: '.$contentType, 'key: '.$options['key'], 'sig: '.$options['sig']));
    //
} else if (!is_null($params) && !empty($params)) {
    curl_setopt($curl, CURLOPT_POST, TRUE);
    curl_setopt($curl, CURLOPT_POSTFIELDS, $params);
    curl_setopt($curl, CURLOPT_HTTPHEADER, array('Content-Type: '.$contentType));
} else {
    curl_setopt($curl, CURLOPT_HTTPHEADER, array('Content-Type: '.$contentType));
}

// Allow for custom requests
if (isset($options['custom_request']) && !empty($options['custom_request'])) {
    curl_setopt($curl, CURLOPT_CUSTOMREQUEST, $options['custom_request']);
}

curl_setopt($curl, CURLOPT_USERAGENT, 'Mozilla/4.0 (compatible; cryptoGlance ' . CURRENT_VERSION . '; PHP/' . phpversion() . ')');

$curlExec = curl_exec($curl);
if ($curlExec === false || curl_errno($curl)) {
    $data = array();
} else {
    $data = json_decode($curlExec, true);
}

if (empty($data)) {
    // return non-jsonfied data
    return $curlExec;
}

curl_close($curl);

return $data;

}

Upvotes: 0

Views: 119

Answers (2)

Danijel
Danijel

Reputation: 12689

Probably is an encoding issue. Here is an example that works correctly on my localhost.

$str = file_get_contents( 'https://s3.amazonaws.com/dolartoday/data.json' );
var_dump( mb_detect_encoding( $str ) );

$str = mb_convert_encoding( $str, "UTF-8" );
var_dump( mb_detect_encoding( $str ) );

var_dump( json_decode( $str ));

Upvotes: 1

mike_l
mike_l

Reputation: 108

a quick call to json_last_error() returns this

Malformed UTF-8 characters, possibly incorrectly encoded

possibly there are a few hidden bad chars (not utf8) in that file.

Upvotes: 0

Related Questions