CODEWITHSUNDEEP
mongodbmongoosemongodb-query
fpena06
fpena06

Reputation: 2426

Rename a sub-document field within an Array

Considering the document below how can I rename 'techId1' to 'techId'. I've tried different ways and can't get it to work.

{
        "_id" : ObjectId("55840f49e0b"),
        "__v" : 0,
        "accessCard" : "123456789",
        "checkouts" : [ 
            {
                "user" : ObjectId("5571e7619f"),
                "_id" : ObjectId("55840f49e0bf"),
                "date" : ISODate("2015-06-19T12:45:52.339Z"),
                "techId1" : ObjectId("553d9cbcaf")
            }, 
            {
                "user" : ObjectId("5571e7619f15"),
                "_id" : ObjectId("55880e8ee0bf"),
                "date" : ISODate("2015-06-22T13:01:51.672Z"),
                "techId1" : ObjectId("55b7db39989")
            }
        ],
        "created" : ISODate("2015-06-19T12:47:05.422Z"),
        "date" : ISODate("2015-06-19T12:45:52.339Z"),
        "location" : ObjectId("55743c8ddbda"),
        "model" : "model1",
        "order" : ObjectId("55840f49e0bf"),
        "rid" : "987654321",
        "serialNumber" : "AHSJSHSKSK",
        "user" : ObjectId("5571e7619f1"),
        "techId" : ObjectId("55b7db399")
    }

In mongo console I tried which gives me ok but nothing is actually updated.

collection.update({"checkouts._id":ObjectId("55840f49e0b")},{ $rename: { "techId1": "techId" } });

I also tried this which gives me an error. "cannot use the part (checkouts of checkouts.techId1) to traverse the element"

collection.update({"checkouts._id":ObjectId("55856609e0b")},{ $rename: { "checkouts.techId1": "checkouts.techId" } })

In mongoose I have tried the following.

collection.findByIdAndUpdate(id, { $rename: { "checkouts.techId1": "checkouts.techId" } }, function (err, data) {});

and 

collection.update({'checkouts._id': n1._id}, { $rename: { "checkouts.$.techId1": "checkouts.$.techId" } }, function (err, data) {});

Thanks in advance.

Upvotes: 11

Views: 6958

Answers (2)

Steven Sucre
Steven Sucre

Reputation: 1

This worked for me, I created this query to perform this procedure and I share it, (although I know it is not the most optimized way):

First, make an aggregate that (1) $match the documents that have the checkouts array field with techId1 as one of the keys of each sub-document. (2) $unwind the checkouts field (that deconstructs the array field from the input documents to output a document for each element), (3) adds the techId field (with $addFields), (4) $unset the old techId1 field, (5) $group the documents by _id to have again the checkout sub-documents grouped by its _id, and (6) write the result of these aggregation in a temporal collection (with $out).

const collection = 'yourCollection'

db[collection].aggregate([
    {
        $match: {
            'checkouts.techId1': { '$exists': true }
        }
    },
    {
        $unwind: {
            path: '$checkouts'
        }
    },
    {
        $addFields: {
            'checkouts.techId': '$checkouts.techId1'
        }
    },
    {
        $project: {
            'checkouts.techId1': 0
        }
    },
    {
        $group: {
            '_id': '$_id',
            'checkouts': { $push: { 'techId': '$checkouts.techId' } }
        }
    },
    {
        $out: 'temporal'
    }
])

Then, you can make another aggregate from this temporal collection to $merge the documents with the modified checkouts field to your original collection.

db.temporal.aggregate([
    {
        $merge: {
            into: collection,
            on: "_id",
            whenMatched:"merge",
            whenNotMatched: "insert"
        }
    }
])

Upvotes: 0

Blakes Seven
Blakes Seven

Reputation: 50406

You were close at the end, but there are a few things missing. You cannot $rename when using the positional operator, instead you need to $set the new name and $unset the old one. But there is another restriction here as they will both belong to "checkouts" as a parent path in that you cannot do both at the same time.

The other core line in your question is "traverse the element" and that is the one thing you cannot do in updating "all" of the array elements at once. Well, not safely and without possibly overwriting new data coming in anyway.

What you need to do is "iterate" each document and similarly iterate each array member in order to "safely" update. You cannot really iterate just the document and "save" the whole array back with alterations. Certainly not in the case where anything else is actively using the data.

I personally would run this sort of operation in the MongoDB shell if you can, as it is a "one off" ( hopefully ) thing and this saves the overhead of writing other API code. Also we're using the Bulk Operations API here to make this as efficient as possible. With mongoose it takes a bit more digging to implement, but still can be done. But here is the shell listing:

var bulk = db.collection.initializeOrderedBulkOp(),
    count = 0;

db.collection.find({ "checkouts.techId1": { "$exists": true } }).forEach(function(doc) {
    doc.checkouts.forEach(function(checkout) {
        if ( checkout.hasOwnProperty("techId1") ) { 
            bulk.find({ "_id": doc._id, "checkouts._id": checkout._id }).updateOne({
                "$set": { "checkouts.$.techId": checkout.techId1 }
            });
            bulk.find({ "_id": doc._id, "checkouts._id": checkout._id }).updateOne({
                "$unset": { "checkouts.$.techId1": 1 }
            });
            count += 2;

            if ( count % 500 == 0 ) {
                bulk.execute();
                bulk = db.collection.initializeOrderedBulkOp();
            }
        }
    });
});

if ( count % 500 !== 0 ) 
    bulk.execute();

Since the $set and $unset operations are happening in pairs, we are keeping the total batch size to 1000 operations per execution just to keep memory usage on the client down.

The loop simply looks for documents where the field to be renamed "exists" and then iterates each array element of each document and commits the two changes. As Bulk Operations, these are not sent to the server until the .execute() is called, where also a single response is returned for each call. This saves a lot of traffic.

If you insist on coding with mongoose. Be aware that a .collection acessor is required to get to the Bulk API methods from the core driver, like this:

var bulk = Model.collection.inititializeOrderedBulkOp();

And the only thing that sends to the server is the .execute() method, so this is your only execution callback:

bulk.exectute(function(err,response) {
    // code body and async iterator callback here
});

And use async flow control instead of .forEach() such as async.each.

Also, if you do that, then be aware that as a raw driver method not governed by mongoose, you do not get the same database connection awareness as you do with mongoose methods. Unless you know for sure the database connection is already established, it is safter to put this code within an event callback for the server connection:

mongoose.connection.on("connect",function(err) {
    // body of code
});

But otherwise those are the only real ( apart from call syntax ) alterations you really need.

Upvotes: 13

Related Questions