CODEWITHSUNDEEP
javascriptpolymer
BrnVrn
BrnVrn

Reputation: 80

How to set an element property from within a callback function

I have this "service" element where I would like to set the property "bookmarks" with the function getTree, which takes a callback function.

My problem is that I don't see how I could reach the property from within the callback function where "this" is undefined!!

<dom-module id="...">
    <style>
    :host {
      display: none;
    }
    </style>
  <script>
    Polymer({
      is: "bookmark-service",
      properties: {
        bookmarks: {
          type: Array,          
          value: function() { return [{title:"init"}]; } 
        }
      },
  created: function() {
     chrome.bookmarks.getTree(
        function(bookmarkTreeNodes) {
            this.bookmarks = bookmarkTreeNodes;
            console.log(this.localName + '#' + this.id + ' in getTree.');
         } ); 
    console.log(this.localName + '#' + this.id + ' was created');
    console.log("Bookmark: " + this.bookmarks[0].title + '.'); 
 },
...

Upvotes: 0

Views: 56

Answers (3)

BrnVrn
BrnVrn

Reputation: 80

That was a part of my problem and I prefer not to use "bind" which I fear may have side effects with this and looks more complicated.

But another problem, was the asynchronous nature of getTree. For this, I had to add an observer.

Also, the properties doesn't even exist in "created" phase, I had to use "ready"

So here is the almost final result:

   properties: {
       bookmarks: {
          type: Array,
          value: function() { return [{title:"init"}]; },
          observer: 'bookready'
        }
    },

  bookready: function(){
    console.log("Bookmark ready: " + this.bookmarks[0].title + '.'); 
  },

  ready: function() {
    var self = this;
    chrome.bookmarks.getTree(
        function(bookmarkTreeNodes) {
           self.bookmarks = bookmarkTreeNodes[0].children;
         } 
    ); 
    console.log(this.localName + '#' + this.id + ' was readied');
    console.log("Bookmark: " + this.bookmarks[0].title + '.'); 
 },

Upvotes: 0

gfpacheco
gfpacheco

Reputation: 3215

You could save a reference for this before calling getTree:

var that = this;
chrome.bookmarks.getTree(function(bookmarkTreeNodes) {
  that.bookmarks = bookmarkTreeNodes;
  console.log(that.localName + '#' + that.id + ' in getTree.');
});

Upvotes: 1

Maria
Maria

Reputation: 5604

You can use bind to set this in your callback function.

 chrome.bookmarks.getTree(
    function(bookmarkTreeNodes) {
        this.bookmarks = bookmarkTreeNodes;
        console.log(this.localName + '#' + this.id + ' in getTree.');
     }.bind(this) );

Upvotes: 1

Related Questions