Dolphin
Dolphin

Reputation: 353

find whether an element exists by a particular tag name in XML

I have an XML file where some sub tags (child node elements) are optional. e.g.

<part>
   <note>
       </rest>
   </note>

   <note>
       <pitch></pitch>
   </note>

   <note>
       <pitch></pitch>
   </note>
</part>

But when I read the XML files by tags, it throws a NullPointerException - since some sub-tags are optional (e.g. rest and pitch in above example). How can I filter this out? I couldn't come across any methods to find whether an element exists by a particular tag name. Even if I have a condition to check whether getElementsByTagName("tag-name") method not returns NULL - still it goes in the condition body and obviously throw the exception. How may I resolve this?

The java code is:

if(fstelm_Note.getElementsByTagName("rest")!=null){
    if(fstelm_Note.getElementsByTagName("rest")==null){
        break;
    }
    NodeList restElmLst = fstelm_Note.getElementsByTagName("rest");
    Element restElm = (Element)restElmLst.item(0);
    NodeList rest = restElm.getChildNodes();

    String restVal = ((Node)rest.item(0)).getNodeValue().toString();

}else if(fstelm_Note.getElementsByTagName("note")!=null){
    if(fstelm_Note.getElementsByTagName("note")==null){
        break;
    }

    NodeList noteElmLst = fstelm_Note.getElementsByTagName("note");
    Element noteElm = (Element)noteElmLst.item(0);

    NodeList note = noteElm.getChildNodes();
    String noteVal = ((Node)note.item(0)).getNodeValue().toString();
}

Any insight or suggestions are appreciated. Thanks in advance.

Upvotes: 8

Views: 39831

Answers (5)

Sarojini2064130
Sarojini2064130

Reputation: 221

First you need to create the nodelist and then check the length of nodelist to check whether the current element exists or not in the xml string.

NodeList restElmLst = fstelm_Note.getElementsByTagName("rest");

if (restElmLst.getLength() > 0) {
    String restVal = restElm.getElementsByTagName("rest").item(0).getTextContent(); 
}                               

Upvotes: 0

Kinjan Bhavsar
Kinjan Bhavsar

Reputation: 1449

Try something like below

bool hasCity = OrderXml.Elements("City").Any();

where OrderXml is parent element.

Upvotes: 0

DanyAlejandro
DanyAlejandro

Reputation: 1468

I had this very same problem (using getElementsByTagName() to get "optional" nodes in an XML file), so I can tell by experience how to solve it. It turns out that getElementsByTagName does not return null when no matching nodes are found; instead, it returns a NodeList object of zero length.

As you may guess, the right way to check if a node exists in an XML file before trying to fetch its contents would be something similar to:

NodeList nl = element.getElementsByTagName("myTag");
if (nl.getLength() > 0) {
    value = nl.item(0).getTextContent();
}

Make sure to specify a "default" value in case the tag is never found.

Upvotes: 14

Pascal Thivent
Pascal Thivent

Reputation: 570615

Your requirements are extremely unclear but I would very likely use the javax.xml.xpath package to parse your XML document with the XML Path Language (XPath).

Have a look at:

But you should try to explain the general problem you are trying to solve rather than the specific problem you're facing. But doing so, 1. you will probably get better answers and 2. the current chosen path might not be the best one.

Upvotes: 1

jwismar
jwismar

Reputation: 12268

It may be that your NodeLists are not null, but are empty. Can you try changing your code like this and see what happens?

NodeList restElmLst = fstelm_Note.getElementsByTagName("rest");
if (restElmLst != null && !restElmLst.isEmpty())
{
    Element restElm = (Element)rests.item(0);
...

etc. (Doublecheck syntax etc., since I'm not in front of a compiler.)

Upvotes: 1

Related Questions