CODEWITHSUNDEEP
c#.netdecimaldivision
Spud1
Spud1

Reputation: 261

Overflow Exception when dividing two decimals in .NET

I'm having an issue trying to divide two decimals and then display the result. Annoyingly this is only happening on our server, and it appears to work perfectly fine if I run the code locally. This is the code that I am trying to run


decimal dOne = -966.96M;
decimal dTwo = 2300M;

decimal dResult = Decimal.Round((dOne / dTwo), 28, 
                               MidpointRounding.AwayFromZero);

The resulting number (as generated from windows calculator) is

-0.43346086956521739130434782608696

This always results in an overflow exception:

System.OverflowException: Value was either too large or too small for a Decimal.
   at System.Decimal.FCallDivide(Decimal& result, Decimal d1, Decimal d2)
   at System.Decimal.op_Division(Decimal d1, Decimal d2)

This does kind of make sense as the resulting number is over 32 decimal places long, and a decimal can only hold up to 28 places..but I am not sure how to perform this division as it appears to be storing the result in the decimal type in memory, before rounding it off and storing it. I've also tried converting it directly to a string rather than storing it in a decimal, but that has the same problem.

Any ideas? Have I done something obviously silly (most probably) and is there a better way to perform this calculation?

Upvotes: 4

Views: 9511

Answers (4)

Brian Gideon
Brian Gideon

Reputation: 48949

I looked at Decimal.Round via Reflector and from what I see it does not ever throw OverflowException so I am betting the exception is coming from the division. Can you edit your answer to include the stack trace?

Also, are you absolutely certain that the numerator and denominator are exactly as you have written? Try tracing the them to the console or a log file when the exception occurs.

You could do something like this:

decimal dOne = -966.96M; 
decimal dTwo = 2300M;  
try
{
  decimal dResult = Decimal.Round((dOne / dTwo), 28, MidpointRounding.AwayFromZero); 
}
catch (OverflowException)
{
  Console.WriteLine(dOne);
  Console.WriteLine(dTwo);
}

Edit: I think I found the code to FCallDivide in the SSCLI. However, it is likely to be different in the release version of the .NET Framework, but I can see from the way it was done in the SSCLI anyway that an overflow exception will be generated in a lot of different ways. The code is quite complicated. If you can construct a short but complete program demonstrating the problem I would submit it as a bug to Microsoft. It is possible that there is a certain bit pattern in those inputs that is confusing the algorithm.

Upvotes: 1

Oliver
Oliver

Reputation: 45071

If it happens on your sever (where you can't debug). Are you really sure that the problem is within these lines?

Maybe you can put a try-catch statement around only the single Decimal.Round statement and giving back some weird value instead. This code could you run on your server again to see if this catch statement really gets called or if the Exception maybe happens somewhere else.

Upvotes: 1

Tomas Aschan
Tomas Aschan

Reputation: 60564

Try converting to double before calculating, and back to decimal afterwards if you need:

decimal dOne = -966.96M;
decimal dTwo = 2300M;

double one = (double)dOne;
double two = (double)dTwo;

double result = one / two;

decimal dResult = (decimal)result; // Additional rounding may be necessary

Upvotes: 4

Jon Skeet
Jon Skeet

Reputation: 1499860

That should run fine. The division isn't guaranteed to return the exactly accurate version - for example, 1 / 3m works fine.

The result clearly isn't outside the range of decimal, so it looks to me like something weird is going on on your server.

One thing to check: is it Decimal.Round that's throwing the exception, or the division itself? Put them into separate statements to find out.

Upvotes: 4

Related Questions