CODEWITHSUNDEEP
androidandroid-layoutandroid-toolbar
alexfi
alexfi

Reputation: 390

Toolbar sets the wrong icon

In my application I want to set a custom menu for the toolbar. The icon that I defined in the menu_settings.xml is an arrow, but when I start the application, it's a three-point menu instead of the arrow (as seen in the Pictures). After hours of research I still can't figure out why it loads this icon instead of the arrow (yes I checked the drawable ;) ). Thank you for solutions and hints!

False Icon 1 False icon after click on three-point menu

SettingsActivity:

public class SettingsActivity extends PreferenceActivity {

private AppCompatDelegate mDelegate;

@Override
protected void onCreate(Bundle savedInstanceState) {
    getDelegate().installViewFactory();
    getDelegate().onCreate(savedInstanceState);

    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_settings);

    Toolbar toolbar = (Toolbar) findViewById(R.id.tool_bar);
    setSupportActionBar(toolbar);

    Intent intent = getIntent();
    boolean hasConfiguredSettings = intent.getBooleanExtra(HAS_CONFIGURED_SETTINGS, false);

    if (hasConfiguredSettings) {
        toolbar.setTitle("Wähle deine Linien!");


    } else {
        // Back button in Toolbar
        toolbar.setNavigationIcon(R.drawable.abc_ic_ab_back_mtrl_am_alpha);
        toolbar.setNavigationOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {
                onBackPressed();
            }
        });
    }

    // Display the fragment as the main content.
    getFragmentManager().beginTransaction()
            .replace(R.id.content, new SettingsFragment())
            .commit();
}

private void setSupportActionBar(Toolbar toolbar) {
    getDelegate().setSupportActionBar(toolbar);
}

private AppCompatDelegate getDelegate() {
    if (mDelegate == null) {
        mDelegate = AppCompatDelegate.create(this, null);
    }
    return mDelegate;
}

@Override
public boolean onCreateOptionsMenu(Menu menu) {
    Intent intent = getIntent();
    boolean hasConfiguredSettings = intent.getBooleanExtra("HAS_CONFIGURED_SETTINGS", false);
    if (hasConfiguredSettings) {
        MenuInflater inflater = getMenuInflater();
        inflater.inflate(R.menu.menu_settings, menu);
        return true;
    }

    return false;
}
}

menu_settings.xml:

<?xml version="1.0" encoding="utf-8"?>
<menu xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto"
xmlns:tools="http://schemas.android.com/tools"
tools:context=".SettingsActivity">
<item
    android:id="@+id/action_checked"
    android:orderInCategory="101"
    android:title="@string/configuration_action_button"
    app:showAsAction="always"
    android:icon="@drawable/ic_action_arrow_right"/>
</menu>

toolbar.xml:

<?xml version="1.0" encoding="utf-8"?>
<android.support.v7.widget.Toolbar  xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto"
  android:layout_height="wrap_content"
  android:layout_width="match_parent"
  android:background="@color/primary"
/>

The toolbar is included with:

<include
    android:id="@+id/tool_bar"
    layout="@layout/toolbar" />

Upvotes: 2

Views: 431

Answers (1)

blizzard
blizzard

Reputation: 5375

You need to use AppCompatDelegate#getMenuInflater instead of Activity#getMenuInflater().

Replace the below line:

MenuInflater inflater = getMenuInflater();

with

MenuInflater inflater = getDelegate().getMenuInflater();

Upvotes: 1

Related Questions