CODEWITHSUNDEEP
cmisra
tk_
tk_

Reputation: 570

Misra C rule 10.1 - false positive warning?

My CCS 6.1 ARM compiler (for LM3Sxxxx Stellaris) throws a warning:

"MISRA Rule 10.1. The value of an expression of integer type shall not be implicitly converted to a different underlying type if the expression is not constant and is a function argument"

for following code:

static uint32_t diagBaseAddress;

void diagCbGetBaseAddress(uint32_t * addr);

...
diagCbGetBaseAddress(&diagBaseAddress); // line where warning is issued
...

I don't see a problem in my code. Is it false positive or my bug?

Upvotes: 1

Views: 912

Answers (1)

Lundin
Lundin

Reputation: 213872

Yes, it is a false positive. Rule 10.1 of MISRA-C:2004 is concerned about implicit type promotions of integer types. Pointers have nothing to do with that rule.

Though make sure that none of the adjacent code lines contain the actual problem, the tool could simply be pointing at the wrong line.

(I can tell it is the 2004 version because it mentions underlying type. In the 2012 version, the concept of underlying type was replaced.)

Upvotes: 1

Related Questions