CODEWITHSUNDEEP
javaandroidsqlite
Brett
Brett

Reputation: 2635

SELECT MAX(column) returning only column name

This has got me all confused! I'm trying to return the max value from a column in my database but the return value is always the name of the column.

The query I use:

private static final String SELECTMAX = "SELECT MAX(?) FROM " + TABLE_NAME ;

The (test) function to return the max value:

public int getMaxValue(String field){

   int r = 0;
   String f[] = new String[] {field};
   Cursor c = this.db.rawQuery(SELECTMAX, f);
   if (c.moveToFirst()) {
       String s = c.getString(0);
       Log.i("XXXXX","Max num: " + s); 
   }
   return r;
}

The column i'm querying is an INTEGER type but the result 's' is always the column name and not the desired value.

Thanks

Upvotes: 3

Views: 1489

Answers (2)

Pentium10
Pentium10

Reputation: 207830

You should make use of the DatabaseUtils.stringForQuery() static method that is already in Android SDK to easily retrieve a value, this example is for String bot there is also method for Long

stringForQuery(SQLiteDatabase db, String query, String[] selectionArgs)

Utility method to run the query on the db and return the value in the first column of the first row.

Something like

String myString=DatabaseUtils.stringForQuery(getDB(),query,selectionArgs);

Upvotes: 1

Chris Diver
Chris Diver

Reputation: 19802

I don't have much experience in sqllite, is ? a parameter of a prepared statments? If so it looks like you are selecting the max of the string representation of your column name, you shouldn't pass the column name as a parameter.

So your query should look like.

SELECT MAX(s) FROM " + TABLE_NAME;

You are effectively executing

SELECT MAX('s') FROM " + TABLE_NAME;

Upvotes: 4

Related Questions