CODEWITHSUNDEEP
python
pookeeshtron
pookeeshtron

Reputation: 135

How to avoid repeating strings?

My code is:

import random
WORDS = ('python', 'football', 'facebook', 'photo') #list of words that will be riddled
word = random.choice(WORDS)
correct = word
jumble = ''
hint = 'hint'
score = 0
while word:
    position = random.randrange(len(word))
    jumble += word[position] 
    word = word[:position] + word[(position + 1):] #creating jumble of correct words
print('Welcome to the game "Anagrams"')
print('Here`s your anagram:', jumble) #Welcoming and giving a jumble to a player
guess = input('\nTry to guess the original word: ')
if guess == correct:
    score += 5
    print('You won! Congratulations!') #end of game in case of right answer
if guess == hint: #situation if player asks a hint
    if correct == WORDS[0]:
        print('snake')
    elif correct == WORDS[1]:
        print('sport game')
    elif correct == WORDS[2]:
        print('social network')
    elif correct == WORDS[3]:
        print('picture of something')
    score += 1
while guess != correct and guess != '': #situation if player is not correct
    print('Sorry, you`re wrong :(')
    guess = input('Try to guess the original word: ')
print('Thank you for participating in game.')
print('Your score is', score)
input('\nPress Enter to end')

When asking hint string :

'Sorry, you`re wrong :('

repeats.
It looks like:

Try to guess the original word: hint
sport game
Sorry, you`re wrong :(

How to make this string appear only in case of wrong guess?

Upvotes: 1

Views: 176

Answers (4)

PM 2Ring
PM 2Ring

Reputation: 55479

In your code, when the player types hint the player gets a hint, but then the program tests the 'hint' string against the correct word. Of course, 'hint' isn't the correct answer, so your program tells them that it's wrong.

Just for fun, I've optimized your code a little, and improved the scoring logic. :)

Your letter-jumbling for loop is quite clever, but there's a more efficient way to do this, using the random.shuffle function. This function shuffles a list, in place. So we need to convert the chosen word into a list, shuffle it, and then join the list back into a string.

I've also replaced your hints logic. Rather than having to do a whole bunch of if tests to see which hint goes with the current word it's much simpler just to store each word and its associated hint as a tuple.

import random

#Words that will be riddled, and their hints
all_words = (
    ('python', 'snake'),
    ('football', 'sport game'),
    ('facebook', 'social network'),
    ('photo', 'picture of something'),
)

#Randomly choose a word
word, hint = random.choice(all_words)

#Jumble up the letters of word
jumble = list(word)
random.shuffle(jumble)
jumble = ''.join(jumble)    

print('Welcome to the game "Anagrams"\n')
print('You may ask for a hint by typing hint at the prompt')
print('Wrong guesses cost 2 points, hints cost 1 point\n')

print("Here's your anagram:", jumble)

score = 0
while True:
    guess = input('\nTry to guess the original word: ')
    if guess == word:
        score += 5
        print('You won! Congratulations!')
        break

    if guess == 'hint':
        #Deduct a point for asking for a hint
        score -= 1
        print(hint)
        continue

    #Deduct 2 points for a wrong word
    score -= 2
    print('Sorry, you`re wrong :(')

print('Thank you for participating in game.')
print('Your score is', score)
input('\nPress Enter to end')

Upvotes: 2

LetzerWille
LetzerWille

Reputation: 5658

change you last while to this:

while guess != correct and guess != '':
    guess = input("Sorry, you`re wrong:( ")

Upvotes: 3

Wolf
Wolf

Reputation: 10238

Lets try to fix some problems:

this

if guess == hint: #situation if player asks a hint

should probably be

elif guess == hint: #situation if player asks a hint

And also this seems wrong to me

while guess != correct and guess != '': #situation if player is not correct
    print('Sorry, you`re wrong :(')
    guess = input('Try to guess the original word: ')

should be probably changed into that (indentation is important):

    guess = input('Try to guess the original word: ')
if guess != correct and guess != '': #situation if player is not correct
    print('Sorry, you`re wrong :(')

I have not tried this corrections in a complete program.

Upvotes: 1

Blckknght
Blckknght

Reputation: 104722

Your special logic for a correct guess and for the special input "hint" is only run once on the very first guess. Your loop for incorrect values always runs after that. I think you want to move all the logic into the loop:

while True:  # loop forever until a break statement is reached
    guess = input('\nTry to guess the original word: ')
    if guess == correct:
        score += 5
        print('You won! Congratulations!')
        break # stop looping
    if guess == hint: # special case, asking for a hint
        if correct == WORDS[0]:
            print('snake')
        elif correct == WORDS[1]:
            print('sport game')
        elif correct == WORDS[2]:
            print('social network')
        elif correct == WORDS[3]:
            print('picture of something')
        score += 1
    else: #situation if player is not correct, and not askng for a hint
        print('Sorry, you`re wrong :(')

I've left out the situation where your code would exit the loop on an empty input. If you want that, you should add it explicitly as an extra case, with a break statement.

Upvotes: 1

Related Questions