user3545006
user3545006

Reputation: 127

PHP insert data using mysql

I'm a newbie in PHP I just studied a while ago. I made some form that on submit, it will insert new data in mysql table. I can't seem to figure out the problem. Here's my code:

<form method="post">
        <table border='2' cellpadding=4 cellspacing=1 width=50% bgcolor=white align=center >
        <br>
            <tr>
                <td><font face=rockwell font size=5 font color=black>Master No.:</td>
                <td class="td-center"><input type="text" name="master_no" /></td>
            </tr>
            <tr>
                <td><font face=rockwell font size=5 font color=black>Alacarte No.:</td>
                <td class="td-center"><input type="text" name="alacarte_no" /></td>
            </tr>
            <tr>
                <td><font face=rockwell font size=5 font color=black>Dessert No.:</td>
                <td class="td-center"><input type="text" name="dessert_no" /></td>
            </tr>
            <tr>
                <td><font face=rockwell font size=5 font color=black>Pasta No.:</td>
                <td class="td-center"><input type="text" name="pasta_no" /></td>
            </tr>
            <tr>
                <td><font face=rockwell font size=5 font color=black>Rice No.:</td>
                <td class="td-center"><input type="text" name="rice_no" /></td>
            </tr>
            <tr>
                <td><font face=rockwell font size=5 font color=black>Wine No.:</td>
                <td class="td-center"><input type="text" name="wine_no" /></td>
            </tr>
            <tr>
                <td><font face=rockwell font size=5 font color=black>Member ID:</td>
                <td class="td-center"><input type="text" name="member_id" /></td>
            </tr>

            <tr>
                <td>&nbsp;</td>
                <td class="td-center">
                    <input type="submit" name="submit" value="Add"/>
                    <input type="Reset"/>
                    <a href="member-profile.php">
                        <input type="button" name="home" value="home"/>
                    </a><br>
                </td>
            </tr>
        </table>
        <?php   

            if (isset($_POST['submit'])) {
                $conn = mysql_connect('localhost', 'root', '');
                 if (!$conn)
                {
                 die('Could not connect: ' . mysql_error());
                }
                mysql_select_db("thesis_sofitel", $conn);

                $master_no=$_POST['master_no'] ;
                $alacarte_no= $_POST['alacarte_no'] ;   
                $dessert_no= $_POST['dessert_no'] ;
                $pasta_no= $_POST['pasta_no'] ; 
                $rice_no= $_POST['rice_no'] ;
                $wine_no= $_POST['wine_no'] ;   
                $member_id= $_POST['member_id'] ;

                mysql_query("INSERT INTO `master_list`(master_no,alacarte_no,dessert_no,pasta_no,rice_no,wine_no,member_id) 
                            VALUES ('$master_no','$alacarte_no','$dessert_no','$pasta_no','$rice_no','$wine_no','$member_id')"); 

                $message = "I was here!!!";
                echo "<script type='text/javascript'>alert('$message');</script>";

            }           
        ?>
    </form>

Upvotes: 1

Views: 101

Answers (1)

DirtyBit
DirtyBit

Reputation: 16772

Fixed a few bugs in your code and changed it to mysqli. This should work now:

1) provide a action attribute in your form, in your case action = "".

2) echo the values to know if they're really being fetched. This is still prone to SQL Injection though. Read more here to know about why/how prepared statements help.

<?php   
    if (isset($_POST['add-submit'])) {
     $con=mysqli_connect("localhost","root","your_pass_here","thesis_sofitel");

    if (mysqli_connect_errno())
     {
       echo "Failed to connect to MySQL: " . mysqli_connect_error();
     }

        echo        $master_no=$_POST['master_no'] ;
        echo        $alacarte_no= $_POST['alacarte_no'] ;   
        echo        $dessert_no= $_POST['dessert_no'] ;
        echo        $pasta_no= $_POST['pasta_no'] ; 
        echo        $rice_no= $_POST['rice_no'] ;
        echo        $wine_no= $_POST['wine_no'] ;   
        echo        $member_id= $_POST['member_id'] ;

$success = mysqli_query($con,"INSERT INTO `master_list`(master_no,alacarte_no,dessert_no,pasta_no,rice_no,wine_no,member_id) 
                            VALUES ('$master_no','$alacarte_no','$dessert_no','$pasta_no','$rice_no','$wine_no','$member_id')");

                            if($success){
                $message = "I was here!!!";
                echo "<script type='text/javascript'>alert('$message');</script>";
                            }
                            else
                                echo "Query Failed.";

mysqli_close($con);

            }           
        ?>

HTML:

<form method="post" action = "">
        <table border='2' cellpadding=4 cellspacing=1 width=50% bgcolor=white align=center >
        <br>
            <tr>
                <td><font face=rockwell font size=5 font color=black>Master No.:</td>
                <td class="td-center"><input type="text" name="master_no" /></td>
            </tr>
            <tr>
                <td><font face=rockwell font size=5 font color=black>Alacarte No.:</td>
                <td class="td-center"><input type="text" name="alacarte_no" /></td>
            </tr>
            <tr>
                <td><font face=rockwell font size=5 font color=black>Dessert No.:</td>
                <td class="td-center"><input type="text" name="dessert_no" /></td>
            </tr>
            <tr>
                <td><font face=rockwell font size=5 font color=black>Pasta No.:</td>
                <td class="td-center"><input type="text" name="pasta_no" /></td>
            </tr>
            <tr>
                <td><font face=rockwell font size=5 font color=black>Rice No.:</td>
                <td class="td-center"><input type="text" name="rice_no" /></td>
            </tr>
            <tr>
                <td><font face=rockwell font size=5 font color=black>Wine No.:</td>
                <td class="td-center"><input type="text" name="wine_no" /></td>
            </tr>
            <tr>
                <td><font face=rockwell font size=5 font color=black>Member ID:</td>
                <td class="td-center"><input type="text" name="member_id" /></td>
            </tr>

            <tr>
                <td>&nbsp;</td>
                <td class="td-center">
                    <input type="submit" name="add-submit" value="Add"/>
                    <input type="Reset"/>
                    <a href="member-profile.php">
                        <input type="button" name="home" value="home"/>
                    </a><br>
                </td>
            </tr>
        </table>

    </form>

EDIT:

The above code works and to clarify it, I tested it myself. Below are the pictures attached.

The main page

After submitting the form

The results in the database

SECOND EDIT:

To show OP that if he had changed the column to INT type, it would still work:

enter image description here

Upvotes: 1

Related Questions