CODEWITHSUNDEEP
iphoneobjective-cinterface-builder
Thomas Anagrius
Thomas Anagrius

Reputation: 926

Unused IBOutlets leaking

So, I'm loading by XIB file and it contains a set of UIBarButtonItems. Some of the items are used when the viewDidLoad: is called.

@interface MyViewController : UIViewController  {

  IBOutlet UIBarButtonItem *addButton;
  IBOutlet UIBarButtonItem *editButton;
  IBOutlet UIBarButtonItem *doneButton;
}

// NB: There are no properties retaining anything.

@end

@implementation MyViewController

- (void)viewDidLoad {

  [super viewDidLoad];

  NSArray *initialToolbarItems = 
    [[NSArray alloc] initWithObjects: addButton, editButton, nil];

  self.toolbarItems = initialToolbarItems;
  [initialToolbarItems release];
}

- (void)dealloc {
  [super dealloc];

  // Nothing else to do here since we are not retaining anything.
  // … or are we? <insert dramatic music here>
}

@end

If I push the above the above ViewController onto a UINavigationController everything seems fine, all the IBOutlets are assigned and behave like expected.

The instant i pop the ViewController from the navigation stack Instruments' Leaks tells me that I am leaking a UIBarButtonItem. Woe is me!

If I change dealloc: to

- (void)dealloc {
  [doneButton release];
  [super dealloc];
}

no leaks occur. The same goes if I use doneButton in viewDidLoad:

  NSArray *initialToolbarItems = 
    [[NSArray alloc] initWithObjects: addButton, editButton, doneButton, nil];

My question: Why is my IBOutlet leaking when I don't use it. I don't retain it at any point. The the NIB loader should own the object, right?

Upvotes: 2

Views: 313

Answers (3)

Rengers
Rengers

Reputation: 15228

Only thing I can think of:

The nib loader treats IBOutlets as strong references. All outlets are retained by default unless you specifically indicate assign. So you still need to release them in dealloc and viewDidUnload.

You can also use a assigned property to make it a weak reference:

@property (nonatomic, assign) IBOutlet UIBarButtonItem *doneButton;

Some reading: http://weblog.bignerdranch.com/?p=95

Upvotes: 2

tadejsv
tadejsv

Reputation: 2092

The array retains them

Upvotes: -1

willcodejavaforfood
willcodejavaforfood

Reputation: 44063

If you have @property with (retain) declared for the your IBOOutlets they will be retained and must be released

Upvotes: 0

Related Questions