CODEWITHSUNDEEP
javascriptarrayssorting
phantomsays
phantomsays

Reputation: 187

Custom sort comparator for javascript string

I have a custom comparator for sorting some strings which doesnt work as expected for sorting strings in descending order.

var list = document.getElementById('mylist');

var items = list.childNodes;
var itemsArr = [];
for (var i in items) {
  if (items[i].nodeType == 1) { // get rid of the whitespace text nodes
    itemsArr.push(items[i]);
  }
}
var sortOrder = "DESC";

itemsArr.sort(function(a, b) {
  switch (sortOrder) {
    case "ASC":
      var val = a.innerHTML.localeCompare(b.innerHTML);
      break;
    case "DESC":
      var val = a.innerHTML.localeCompare(b.innerHTML);
      if (val === 1)
        val = -1;
      if (val === -1)
        val = 1;
      break;

  }
  return val
});

/*itemsArr.sort(function(a, b) {
  return a.innerHTML == b.innerHTML
          ? 0
          : (a.innerHTML > b.innerHTML ? 1 : -1);
});*/

for (i = 0; i < itemsArr.length; ++i) {
  list.appendChild(itemsArr[i]);
}
<ul id="mylist">
  <li id="list-item3">Service</li>
  <li id="list-item4">Vendor</li>
  <li id="list-item2">Service_Type</li>
  <li id="list-item1">Call_Date</li>
  <li id="list-item3">Customer Sat Rating</li>
  <li id="list-item4">TTA</li>
  <li id="list-item2">Support_Rep</li>
  <li id="list-item1">Source_State</li>
  <li id="list-item3">Severity</li>
  <li id="list-item4">Customer_Type</li>
  <li id="list-item2">CALL ID</li>
  <li id="list-item1">Resolved_Ontime</li>
  <li id="list-item2">Product</li>
  <li id="list-item1">Minutes_On_Phone</li>
</ul>

For a different data I sorted earlier it worked fine for both ascending and descending. For the current html data it doesnt. Can someone please show where I am incorrect?

Upvotes: 0

Views: 1624

Answers (1)

Malk
Malk

Reputation: 11983

You are setting it to DESC and then right back again:

case "DESC":
  var val = a.innerHTML.localeCompare(b.innerHTML);
  if (val === 1)
    val = -1;
  if (val === -1)
    val = 1;
  break;

Change it to:

case "DESC":
  var val = -1 * a.innerHTML.localeCompare(b.innerHTML);
  break;

Upvotes: 2

Related Questions