CODEWITHSUNDEEP
c++int
bad
bad

Reputation: 92

loop repeats without prompting the user again?

I have this snippets of code from my original long program, and as much as it looks simple, it doesn't work correctly! I am brand-new to c++ language, but I know in Java that would be the way to do it (Regardless of the syntax).

Simply put, this should ask the user for an input to answer the following multiplication (5*5), however, it should also check if the user entered a wrong input (not number), keep asking the user again and again... Somehow, it keeps running forever without taking a new input!!

I hope to get, not only an answer, but also a reason for such an error!

int main() {
  int userAnswer;
  bool isValidAnswer = true;

  cout << 5 << " * " << 5 << " = ";
  cin >> userAnswer;
  cin.ignore();

  do {
    if (cin.fail()) { //user input is not an integer
      cout << "Your answer is not valid! Please enter only a natural number: ";
      cin >> userAnswer;
      cin.ignore();
    } else {
      isValidAnswer = false;
    }
  } while (isValidAnswer);

  return 0;
}

Upvotes: 0

Views: 61

Answers (2)

Ironcache
Ironcache

Reputation: 1759

First, cin.fail() is not going to adequately check if your answer is a natural number or not with the type set to int (could also be negative).

Second, your boolean isValidAnswer is really checking if it's is an invalid answer.

Third (and most importantly), as another answer suggests, you should put in cin.clear() to clear the failure state, and then followed by cin.ignore(), which will remove the failed string from cin.

Fourth, cin will only check if an int exists somewhere in the string. You'll need to perform your own string comparison to determine if the entire input is a int (see answer below, based on this answer).

Updated:

#include <iostream>
#include <string>
#include <cstdlib>                                                                                                                                                                                    
using namespace std;

bool isNum(string line)
{
    char* p;
    strtol(line.c_str(), &p, 10);
    return *p == 0;
}

int main() {
  int userAnswer;
  string input;
  bool isInvalidAnswer = true;
  cout << 5 << " * " << 5 << " = ";
  while (isInvalidAnswer) {
    if (!(cin >> input) || !isNum(input)) {
      cout << "Answer is not a number! Please try again:\n";
      cin.clear();
      cin.ignore();
    }
    else {
      userAnswer = atoi(input.c_str());
      if (userAnswer < 0) { //user input is not an integer
        cout << "Answer is not a natural number! Please try again:\n";
      } else {
        isInvalidAnswer = false;
      }
    }
  }
  cout << "Question answered!\n";
  return 0;
}

Upvotes: 0

chasep255
chasep255

Reputation: 12175

Well you need to clear the error state before accepting new input. Call cin.clear() then cin.ignore() before trying to read input again.

I would do something like.

cout << "Enter a number: ";
cin >> number;
while(cin.fail())
{
    cin.clear();
    cin.ignore(1000, '\n'); //some large number of character will stop at new line
    cout << "Bad Number Try Again: ";
    cin >> number;
}

Upvotes: 2

Related Questions