CODEWITHSUNDEEP
android
Veeresh
Veeresh

Reputation: 373

Front Camera in Camera2 not capturing image

I have the code for the Camera2 from https://github.com/googlesamples/android-Camera2Basic.

The problem i'm facing is that when i turn to my Front Camera, i cannot capture pictures but works fine with Back Camera.

Has anyone implemented the Camera2 Api please help!

Here's the code snippet:

private void setUpCameraOutputs(int width, int height) {
    Activity activity = getActivity();
    CameraManager manager = (CameraManager) activity.getSystemService(Context.CAMERA_SERVICE);
    try {
        for (String cameraId : manager.getCameraIdList()) {
            CameraCharacteristics characteristics
                    = manager.getCameraCharacteristics(cameraId);

            // We don't use a front facing camera in this sample.
            int facing = characteristics.get(CameraCharacteristics.LENS_FACING);
            Log.i(TAG,"Front Cam ID: "+ facing);
            if (characteristics.get(CameraCharacteristics.LENS_FACING)==CameraCharacteristics.LENS_FACING_FRONT)
            {



                StreamConfigurationMap map = characteristics.get(
                        CameraCharacteristics.SCALER_STREAM_CONFIGURATION_MAP);


                // For still image captures, we use the largest available size.
                Size largest = Collections.max(
                        Arrays.asList(map.getOutputSizes(ImageFormat.JPEG)),
                        new CompareSizesByArea());
                mImageReader = ImageReader.newInstance(largest.getWidth(), largest.getHeight(),
                        ImageFormat.JPEG, /*maxImages*/2);
                mImageReader.setOnImageAvailableListener(
                        mOnImageAvailableListener, mBackgroundHandler);

                // Danger, W.R.! Attempting to use too large a preview size could  exceed the camera
                // bus' bandwidth limitation, resulting in gorgeous previews but the storage of
                // garbage capture data.
                mPreviewSize = chooseOptimalSize(map.getOutputSizes(SurfaceTexture.class),
                        width, height, largest);

                // We fit the aspect ratio of TextureView to the size of preview we picked.
                int orientation = getResources().getConfiguration().orientation;
                if (orientation == Configuration.ORIENTATION_LANDSCAPE) {
                    mTextureView.setAspectRatio(
                            mPreviewSize.getWidth(), mPreviewSize.getHeight());
                } else {
                    mTextureView.setAspectRatio(
                            mPreviewSize.getHeight(), mPreviewSize.getWidth());
                }

                mCameraId = cameraId;
                return;
            }
            else
            {
                onActivityCreated(Bundle.EMPTY);
            }
        }
    } catch (CameraAccessException e) {
        e.printStackTrace();
    } catch (NullPointerException e) {
        // Currently an NPE is thrown when the Camera2API is used but not supported on the
        // device this code runs.
        ErrorDialog.newInstance(getString(R.string.camera_error))
                .show(getChildFragmentManager(), FRAGMENT_DIALOG);
    }
}

Upvotes: 11

Views: 7625

Answers (5)

Vishnu V S
Vishnu V S

Reputation: 355

Plz try this code for capture

case STATE_WAITING_LOCK: {
                Integer afState = result.get(CaptureResult.CONTROL_AF_STATE);
                if (afState == null) {
                    captureStillPicture();
                } else if (CaptureResult.CONTROL_AF_STATE_FOCUSED_LOCKED == afState ||
                        CaptureResult.CONTROL_AF_STATE_NOT_FOCUSED_LOCKED == afState ||
                         CaptureResult.CONTROL_AF_STATE_INACTIVE == afState /*add this*/) {
                    // CONTROL_AE_STATE can be null on some devices
                    Integer aeState = result.get(CaptureResult.CONTROL_AE_STATE);
                    if (aeState == null || aeState == CaptureResult.CONTROL_AE_STATE_CONVERGED) {
                        mState = STATE_PICTURE_TAKEN;
                        captureStillPicture();
                    } else {
                        runPrecaptureSequence();
                    }
                }
                break;
            }

Upvotes: -1

D-rk
D-rk

Reputation: 5919

The problem is that many front-facing cameras have a fixed focus distance. So after the autofocus trigger in lockFocus() the autofocus state (CONTROL_AF_STATE) remains INACTIVE and the autofocus trigger does nothing.

So in order to make it work you need to check whether autofocus is supported or not. To do so, add the following to setUpCameraOutputs():

int[] afAvailableModes = characteristics.get(CameraCharacteristics.CONTROL_AF_AVAILABLE_MODES);

if (afAvailableModes.length == 0 || (afAvailableModes.length == 1
        && afAvailableModes[0] == CameraMetadata.CONTROL_AF_MODE_OFF)) {
    mAutoFocusSupported = false;
} else {
    mAutoFocusSupported = true;
}

Finally don't lock focus if its not supported when you want to take a picture:

private void takePicture() {
    if (mAutoFocusSupported) {
        lockFocus();
    } else {
        captureStillPicture();
    }
}

Upvotes: 30

0xPixelfrost
0xPixelfrost

Reputation: 10444

@ArvindSingh's solution is not the best one, because you would also disable the focus functionality for the back camera. A better solution would be to do a camera facing check inside the takePicture like that:

private void takePicture() {
    if (CameraCharacteristics.LENS_FACING_FRONT == mSelectedFacing) {
        // front camera selected, so take a picture without focus
        captureStillPicture();
    } else {
        // back camera selected, trigger the focus before creating an image
        lockFocus();
    }
}

For this solution you only need to save the current used facing somewhere like here in mSelectedFacing

Upvotes: 4

Getaw Dejen
Getaw Dejen

Reputation: 351

In lockFocus() method, replace line

mCaptureSession.capture(mPreviewRequestBuilder.build(),
                                              mCaptureCallback,    mBackgroundHandler);

with

captureStillPicture();

And to prevent Unwanted orientation you can use

/** * Conversion from screen rotation to JPEG orientation. */

   static {
       ORIENTATIONS.append(Surface.ROTATION_0, 270);
       ORIENTATIONS.append(Surface.ROTATION_90, 0);
       ORIENTATIONS.append(Surface.ROTATION_180, 180);
       ORIENTATIONS.append(Surface.ROTATION_270, 270);
   }

Upvotes: 1

Arvind Singh
Arvind Singh

Reputation: 149

For Camera2 Api, Google's example for video works great for both front and back camera, but for Image capturing, Google's example works only for back camera and not for front camera.
Solution which works for me is

In lockFocus() method, replace line 

mCaptureSession.capture(mPreviewRequestBuilder.build(),
                                                  mCaptureCallback, mBackgroundHandler);

with

captureStillPicture();

Hope this will help!!

Upvotes: 14

Related Questions