CODEWITHSUNDEEP
javaandroidretrofit
DutchProgrammer
DutchProgrammer

Reputation: 107

Android/Java retrofit: Class cannot be converted to Callback

I'm new to retrofit and i am trying te get a json response to an object called RootObject. The error that i am stuck with is :

"Error:(21, 44) error: incompatible types: NewsController cannot be converted to Callback>"

Does someone now my mistake here? thanks in regards!

public class NewsController {
        public void getNews(){
            Retrofit retrofit = new Retrofit.Builder().baseUrl("apilink").addConverterFactory(GsonConverterFactory.create()).build();
            GetNewsService service = retrofit.create(GetNewsService.class);
            try {
                service.GetNewsItems().enqueue(this); //asynchronous
                Response<List<RootObject>> response = service.GetNewsItems().execute(); //synchronous
            }
            catch (IOException e){

            }
        }
}

class to put the data:

public class RootObject implements Serializable {
   public ArrayList<Result> results ;
   public int nextId;

    public ArrayList<Result> getResults() { return results; }
    public int getNextId() { return nextId; }

    public String toString() {
        return String.format("JEEJ" + nextId);
    }
}

Interface:

public interface GetNewsService {
    @GET("/Articles")
    Call<List<RootObject>> GetNewsItems();
}

Upvotes: 3

Views: 3649

Answers (2)

iagreen
iagreen

Reputation: 31996

@megh vidani's answer works, but he had you switch your code from Retrofit 2 to Retrofit 1. Here is how to do it in Retrofit 2. You would need to go back to your original gradle settings, etc. -- 

public class NewsController {
    public void getNews(){
        Retrofit retrofit = new Retrofit.Builder().baseUrl("apilink").addConverterFactory(GsonConverterFactory.create()).build();
        GetNewsService service = retrofit.create(GetNewsService.class);
        service.GetNewsItems().enqueue(new Callback<List<RootObject>>()  {
            @Override
            public void onResponse(Response<List<RootObject>> response) { 
                // Handle your response
                // Note HTTP errors are delivered here, you can check
                // response.isSuccess() or response.code() to determine
                // HTTP failures
            }

            @Override
            public void onFailure(Throwable t) {
                // Network errors
            }
        });
   }
}

Upvotes: 2

Megh Vidani
Megh Vidani

Reputation: 635

First of all, change your interface to this:

public interface GetNewsService { 
  @GET("/Articles") 
  void GetNewsItems(Callback<List<RootObject>> cb);
}

Also change your newsController class.

public class NewsController {
    private RestAdapter restAdapter;
    static final String API_URL = "[Enter your API base url here]";
    public void getNews(){
        OkHttpClient mOkHttpClient = new OkHttpClient();
        mOkHttpClient.setConnectTimeout(15000,TimeUnit.MILLISECONDS);
        mOkHttpClient.setReadTimeout(15000,TimeUnit.MILLISECONDS);
        restAdapter = new RestAdapter.Builder().setEndpoint(API_URL).setClient(new OkClient(mOkHttpClient)).setLogLevel(RestAdapter.LogLevel.FULL) .build();
        GetNewsService service = restAdapter.create(GetNewsService.class);

        Callback<List<RootObject> cb = new Callback<List<RootObject>>() {
          @Override 
          public void success(List<RootObject> rootObjectList, Response response) { 
             //whatever you want to do with the fetched news items
          } 

          @Override 
          public void failure(RetrofitError error) { 
            //whatever you want to do with the error
          } 
        };
        service.GetNewsItems(cb);    
    }
}

You'll need to add the following dependencies in your build.gradle:

compile 'com.squareup.retrofit:retrofit:1.9.0'
compile 'com.google.code.gson:gson:2.3.1'
compile 'com.squareup.okhttp:okhttp:2.4.0'

Upvotes: 3

Related Questions