CODEWITHSUNDEEP
cocoakey-value-coding
Bakaburg
Bakaburg

Reputation: 3311

Key-Value Coding and methods calling

It's a question about good programming techniques with Cocoa.
When you want to call a method on one property of your class, should you use KVC to get the receiver or just put the name of your property?

Example, KVC:

[[self property] myMethod];

Example, simple:

[property myMethod];

Thanks!

Upvotes: 1

Views: 198

Answers (2)

Peter Hosey
Peter Hosey

Reputation: 96333

Example, KVC:

[[self property] myMethod];

That isn't KVC. The KVC way is:

[[self valueForKey:@"myProperty"] myMethod]

There is no reason to do this when you know the property at compile time; you can just ask for the property value or the ivar value directly. With KVO and (on the Mac) Bindings already implemented, there's not much reason to use KVC directly, as KVO and Bindings use it for you.

Example, simple:

[property myMethod];

That doesn't access the property; it accesses the ivar.

You're only accessing the property when you send an accessor message to the property's holder (self in your examples). It doesn't matter whether you use [self property] or self.property, as they're equivalent; either one is a property message to self, with whatever side effects that implies.

That's the key difference: Hitting the accessor may cause side effects, whereas accessing the ivar directly never will.

Hence, the best practice: Use the property in all your instance methods (as you probably want the accessors' side effects), except in init methods and dealloc, where side effects would be a bad thing. (As a general rule, you should not send messages to a half-initialized or half-deallocked object. The exception is when you explicitly commented the method as being part of your init/dealloc process and therefore wrote it to be safe to use in such circumstances.)

Upvotes: 2

John Franklin
John Franklin

Reputation: 4912

I believe the formal version is technically correct as that will guarantee any side-effects from a funky getter. (To make sure, make a custom getter that includes NSLog("in getter!") and let us know if it works.)

For setting you have to use the [self setProperty:foo]; as property = foo bypasses the setter and can lead to memory leaks.

If it feels more natural to you, the dot notation (e.g., self.property and self.property = foo) is identical to [self property] and [self setProperty:foo].

Upvotes: 0

Related Questions