Creating edit function in the same controller laravel

Question

So I have a create function in my controller as shown below and my routes is as such, my question is is there a way for me to put a condition to different create and edit in the same function as both have quite similar coding. Can someone enlighten me pls?

class ManageAccountsController extends Controller
{
    public function index() {
        $users = User::orderBy('name')->get();
        $roles = Role::all();

        return view('manage_accounts', compact('users', 'roles'));
    }

    public function update()
    {
            // process the form here

    // create the validation rules ------------------------
        $rules = array(
        'name'             => 'required',                        // just a normal required validation
        'email'            => 'required|email|unique:users',     // required and must be unique in the user table
        'password'         => 'required|min:8|alpha_num',
        'password_confirm' => 'required|same:password',           // required and has to match the password field
        'mobile'           => 'required', 
        'role_id'          => 'required'
        );

    // do the validation ----------------------------------
    // validate against the inputs from our form
        $validator = Validator::make(Input::all(), $rules);

    // check if the validator failed -----------------------
        if ($validator->fails()) {

        // redirect our user back to the form with the errors from the validator

            $input = Input::except('password', 'password_confirm');

            $input['autoOpenModal'] = 'true'; //Add the auto open indicator flag as an input.
            return redirect()
            ->back()
            ->withInput($input)
            ->withErrors($validator);

        } else {
        // validation successful ---------------------------

        // user has passed all tests!
        // let user enter the database

        // create the data for our user
            $user = new User;
            $user->name     = Input::get('name');
            $user->email    = Input::get('email');
            $user->password = Hash::make(Input::get('password'));
            $user->mobile   = Input::get('mobile');
            $user->role_id  = Input::get('role_id');

        // save our user
            $user->save();

        // redirect ----------------------------------------
        // redirect our user back to the form so they can do it all over again
            Session::flash('flash_message', 'User successfully added!');

            return redirect()->back();

        }
    }
}

routes.php

Route::get('manage_accounts', 'ManageAccountsController@index');
Route::post('manage_accounts', 'ManageAccountsController@update');

shwe_jay · Accepted Answer

Why don't you try moving some of this code out of your controller. If you were to use Repositories, then you would be able to encapsulate some of your logic in order to use it for both functions.

Also you can handle all this validation without writing all the extra code into your controller - see http://laravel.com/docs/5.0/validation#form-request-validation.

This may all seem a bit overkill at first, but once you get the hang of it, your code will be much more manageable and extendable.

(for more on these I would thoroughly recommend Jeffery Way's Laracasts https://laracasts.com/ - this helped me a lot when I was learning Laravel)

//  routes.php

// http://laravel.com/docs/5.0/controllers#restful-resource-controllers
Route::resource('manage_accounts', 'ManageAccountsController');


// ManageAccountsController.php

use Illuminate\Http\Request;
use Illuminate\Routing\Controller;

class ManageAccountsController extends Controller
{

    public $userRepository;


    public function __construct(UserRepository $userRepository)
    {
        $this->userRepository = $userRepository;
    }

    public function index() {

        $users = User::orderBy('name')->get();
        $roles = Role::all();
        return view('manage_accounts', compact('users', 'roles'));
    }

    public function store(StoreUserRequest $request)
    {
      // validation already handled using this: http://laravel.com/docs/5.0/validation#form-request-validation
        $this->userRepository->upsert($request)

        Session::flash('flash_message', 'User successfully added!');

        return redirect()->back();

    }

    public function update(StoreUserRequest $request, $id)
    {
        // validation already handled using this: http://laravel.com/docs/5.0/validation#form-request-validation
        $this->userRepository->upsert($request, $id)

        Session::flash('flash_message', 'User successfully updated!');

        return redirect()->back();

    }
}


// UserRepository.php
class UserRepository {



    public function upsert($data, $id = null)
    {

            // You will also need something like this
            if(isset($data['id']))
            {
                $user = $this->user->find($data['id']);
            }
            else {
                $user = new User;
            }


            $user->name     = $data['name'];
            $user->email    = $data['email'];
            $user->password = Hash::make($data['password']);
            $user->mobile   = $data['mobile'];
            $user->role_id  = $data['role_id'];

            // save our user
            $user->save();

            return $user;
        }
    }

}

Please use the code here as a guide (I have written this in a hurry and it will certainly contain errors). Have a quick read up on repositories and I think it should all make sense.

The basic premise here is to separate out code that you want to re-use rather than squashing it all into the same function.

Hope this helps!

Creating edit function in the same controller laravel

Answers (2)

Related Questions