CODEWITHSUNDEEP
c#asp.netresponseepplus
sd_dracula
sd_dracula

Reputation: 3896

Response.End causing System.Threading.ThreadAbortException

I have a try catch in a button_Click() method where I use EPPlus to save some data to an Excel spreadsheet.

try 
{
 .... Some calculations here...
   //Create Excel output.
                Response.Clear();
                Response.ContentType = "application/vnd.openxmlformats-officedocument.spreadsheetml.sheet";
                Response.AddHeader("content-disposition", "attachment;  filename=Report " +
                                   DateTime.Today.Day.ToString() + "-" + DateTime.Today.Month.ToString() + "-" +
                                   DateTime.Today.Year.ToString() + " " + DateTime.Now.Hour + "-" +
                                   DateTime.Now.Minute + "-" + DateTime.Now.Second + ".xlsx");
                package.SaveAs(Response.OutputStream);
                Response.End();
}

cach()
{
   LogException();
}

I get an error System.Threading.ThreadAbortException, which I get because of Response.End() above, I get that.

What is really annoying is that despite that on my dev machine it still outputs the file but when I place the website on the server, it logs the error, the page keeps loading infinitely and never spits out the file.

Anyone have an idea what is going wrong there?

Upvotes: 0

Views: 829

Answers (2)

meda
meda

Reputation: 45490

Just catch ThreadAbortException and do nothing. You can safely ignore this exception.

EDIT: Get rid of the log, or add a check to not log on ThreadAbortException

catch(Exception ex){
    if (ex is System.Threading.ThreadAbortException)
    {
        //do nothing
        return;
    }else{
        LogException(ex);
    }
}

Upvotes: 3

Darren Gourley
Darren Gourley

Reputation: 1808

When Response.Redirect or Response.End is in a try block, the code in the catch block is executed.

You can catch and absorb this TreadAbortException.

You could also consider adding a finally block that ends the response instead of having it in the try. If you catch an exception you could amend the response and send back an error to the client.

Upvotes: 1

Related Questions