CODEWITHSUNDEEP
c++raytracingrandom
user5044221
user5044221

Reputation:

Raytracing incorrect soft shadow sampling

Hello I'm studying on a raytracing algorithm and I'm stuck at monte carlo algorithm. While rendering without area light my render output was correct but when i added area light implementation to the source code for generating soft shadow I've encountered a problem.

Here is the before-after output image.

enter image description here

When I moved blue sphere down the problem is continuing (notice that artifact continues when sphere along the white dotted line). Note this sphere and arealight is the same z offset. When I bring blue sphere to front of screen, the artifact is gone. I think problem is caused by uniform sampling cone or sampling sphere function but not sure.

Here is function:

template <typename T>
CVector3<T> UConeSample(T u1, T u2, T costhetamax,
const CVector3<T>& x, const CVector3<T>& y, const CVector3<T>& z) {
   T costheta = Math::Lerp(u1, costhetamax, T(1));
   T sintheta = sqrtf(T(1) - costheta*costheta);
   T phi = u2 * T(2) * T(M_PI);

   return cosf(phi) * sintheta * x +
          sinf(phi) * sintheta * y +
          costheta * z;
}

I'm generating random float u1, u2 value from van Der Corput sequence. This is sphere sampling method

CPoint3<float> CSphere::Sample(const CLightSample& ls, const CPoint3<float>& p, CVector3<float> *n) const {
   // translate object to world space
   CPoint3<float> pCentre = o2w(CPoint3<float>(0.0f));
   CVector3<float> wc = Vector::Normalize(pCentre - p);
   CVector3<float> wcx, wcy;
   //create local coordinate system from wc for uniform sample cone
   Vector::CoordinateSystem(wc, &wcx, &wcy);

   //check if inside, epsilon val. this is true?
   if (Point::DistSquare(p, pCentre) - radius*radius < 1e-4f)
      return Sample(ls, n);

   // Else outside evaluate cosinus theta value
   float sinthetamax2 = radius * radius / Point::DistSquare(p, pCentre);
   float costhetamax = sqrtf(Math::Max(0.0f, 1.0f - sinthetamax2));

   // Surface properties
   CSurfaceProps dg_sphere;
   float thit, ray_epsilon;
   CPoint3<float> ps;

   //create ray direction from sampled point then send ray to sphere
   CRay ray(p, Vector::UConeSample(ls.u1, ls.u2, costhetamax, wcx, wcy, wc), 1e-3f);
   // Check intersection against sphere, fill surface properties and calculate hit point
   if (!Intersect(ray, &thit, &ray_epsilon, &dg_sphere))
      thit = Vector::Dot(pCentre - p, Vector::Normalize(ray.d));

   // Evaluate surface normal
   ps = ray(thit);
   *n = CVector3<float>(Vector::Normalize(ps - pCentre));

   //return sample point
   return ps;
}

Does anyone have any suggestions? Thanks.

Upvotes: 4

Views: 656

Answers (1)

user5044221
user5044221

Reputation:

I solved the problem.

Ray tracing needs more complex RNG (one of them "The Mersenne Twister" pseudorandom number generator) and good shuffling algorithm.

enter image description here

I hope it will help. Thanks to everyone who posted comments.

Upvotes: 1

Related Questions