CODEWITHSUNDEEP
javascriptangularjs
JWDev
JWDev

Reputation: 856

AngularJS $http is not defined even though it is

I'm trying to pull data from a JSON API, using the $http method, however AngularJS keeps throwing an error that $http is not defined, even though it has been defined in the controller.

Controller:

app.controller("CompaniesController", ['$scope', '$http', 'companyService', function($scope, $http, companyService) {
    $scope.title = 'Companies';
    $scope.title_sub = 'Add Company';

   $scope.add = function(newCompany) {
       companyService.addCompany( {
           id: newCompany.id,
           name: newCompany.name,
           primary_contact: newCompany.primary_contact,
           address: newCompany.address,
           function: newCompany.function,
           telephone: newCompany.phone,
           fax: newCompany.fax,
           url: newCompany.url
       });
    };

    $scope.companies = companyService.getCompanies();

}]);

Service:

app.service('companyService',[function(){
    var companies = [];
    return {
        addCompany: function(company){
            companies.push(company);
        },
        getCompanies: function(){
            $http({method: 'GET', url: '/api/example/view/4553'}).success(function(data) {
                var companies = data; // response data
            });
            return companies;
        }
    }
}]);

Upvotes: 2

Views: 522

Answers (1)

potatopeelings
potatopeelings

Reputation: 41065

You should inject $http into your 'companyService' service, like so

app.service('companyService',['$http', function($http){
    ...

By the way, you can remove it from 'CompaniesController' because you don't use it there directly.

Upvotes: 5

Related Questions