CODEWITHSUNDEEP
jqueryslicewrapall
csbourne
csbourne

Reputation: 957

.slice and .wrapall

I'm using a bit of code suggested by a member on stackoverflow and adapted by me to wrap every 3 list items as part of a mega menu. The code is:

var lis = $("ul > li");
for(var i = 0; i < ls.length; i+=3) {
  lis.slice(i, i+3).wrapAll("<div class='new'></div>");
}

Unfortunately this will grab child li's from the next parent menu to fill up the 'quota' of 3 li's in a div. This is of course massively messing up my menus. For an example please visit here.

Does anyone have any suggestion how I could fix this up?

Upvotes: 5

Views: 2318

Answers (2)

jAndy
jAndy

Reputation: 236102

Your problem is your selector. Since sizzle works right to left, it will just query all LI elements which have an UL element as direct parent (which usually, is always the case).

So, seperate your ULs.

$('ul').each(function(){
   var $lis = $(this).children('li');
   for(var i = 0, len = $lis.length; i < len; i+=3){          
     $lis.slice(i, i+3).wrapAll("<div class='new'></div>");
  }
});

Upvotes: 6

Reigel Gallarde
Reigel Gallarde

Reputation: 65274

have you tried applying it withe the use of the class as ht selector like this?

var lis = $("ul.list-content > li");
for(var i = 0; i < lis.length; i+=3) {
  lis.slice(i, i+3).wrapAll("<div class='new'></div>");
}

But if you did not know, I'm warning you that you are breaking the dom.. you are putting div on ul which is not good.. ;)

Upvotes: 0

Related Questions