CODEWITHSUNDEEP
pythondjangodjango-formscleaned-data
saturdayplace
saturdayplace

Reputation: 8730

Problems raising a ValidationError on a Django Form

I'm trying to validate that a submitted URL doesn't already exist in the database.

The relevant parts of the Form class look like this:

from django.contrib.sites.models import Site
class SignUpForm(forms.Form):
    # ... Other fields ...
    url = forms.URLField(label='URL for new site, eg: example.com')

    def clean_url(self):
        url = self.cleaned_data['url']
        try:
            a = Site.objects.get(domain=url)

        except Site.DoesNotExist:
            return url

        else:
            raise forms.ValidationError("That URL is already in the database.  Please submit a unique URL.")

    def clean(self):
        # Other form cleaning stuff.  I don't *think* this is causing the grief

The problem is, regardless of what value I submit, I can't raise the ValidationError. And if I do something like this in the clean_url() method:

if Site.objects.get(domain=url):
    raise forms.ValidationError("That URL is already in the database.  Please submit a unique URL.")

then I get a DoesNotExist error, even for URLs that already exist in the Database. Any ideas?

Upvotes: 5

Views: 12076

Answers (4)

user508418
user508418

Reputation: 1

Well I logged in cause I found this via Google with a similar issue and wanted to add a comment to Carl Meyers post noting that using self._errors is totally valid as per the Django docs:

http://docs.djangoproject.com/en/1.2/ref/forms/validation/#cleaning-and-validating-fields-that-depend-on-each-other

Upvotes: 0

saturdayplace
saturdayplace

Reputation: 8730

django channel in IRC saved me here. The problem was that the URLField.clean() does two things I wasn't expecting:

  1. If no URL scheme is present (eg, http://) the method prepends 'http://' to the url
  2. the method also appends a trailing slash.

The results are returned and stored in the form's cleaned_data. So I was checking cleaned_data['url'] expecting something like example.com and actually getting http://example.com/. Suffice to say, changing my clean_url() method to the following works:

def clean_url(self):
        url = self.cleaned_data['url']        
        bits = urlparse(url)
        dom = bits[1]
        try:
            site=Site.objects.get(domain__iexact=dom)
        except Site.DoesNotExist:
            return dom
        raise forms.ValidationError(u'That domain is already taken.  Please choose another')

Upvotes: 4

Igorekk
Igorekk

Reputation: 256

I think, you can return '' and fill _errors.

msg = u"That URL is already in the database.  Please submit a unique URL."
self._errors["url"]=ErrorList([msg])
return ''

or

from django.contrib.sites.models import Site
class SignUpForm(forms.Form):
    # ... Other fields ...

url = forms.URLField(label='URL for new site, eg: example.com')

def clean_url(self):
    url = self.cleaned_data['url']
    try:
        a = Site.objects.get(domain=url)
        raise forms.ValidationError("That URL is already in the database.  Please submit a unique URL.")
    except Site.DoesNotExist:
        return url
    return ''

def clean(self):
    # Other form cleaning stuff.  I don't *think* this is causing the grief

Upvotes: 0

S.Lott
S.Lott

Reputation: 391942

I do it this way. It's slightly simpler.

try:
    a = Site.objects.get(domain=url)
    raise forms.ValidationError("That URL is already in the database.  Please submit a unique URL.")
except Site.DoesNotExist:
    pass
return url

Upvotes: 1

Related Questions