CODEWITHSUNDEEP
javascripthtml
dmaster
dmaster

Reputation: 41

document.getElementById returns null for unknown reason

The code is for a slider to switch images. When I run the page I get this error:

Cannot set property 'onclick' of null.

HTML:

   <!DOCTYPE html>
   <html lang="en">
   <head>
<meta charset="UTF-8">
<title>Image Slider</title>
<link rel="stylesheet" type="text/css" href="sliderswag.css">
<script language="javascript" type="text/javascript" src="imgslidescript.js"></script>
</head>
<body>
<div id="box">
    <img id="main" src="http://lmetar.com/oscar1.jpg">
    <img id="left" src="http://lmetar.com/left.png">
    <img id="right" src="http://lmetar.com/right.png">
</div>

JavaScript:

 document.getElementById('left').onclick = slideChange;
document.getElementById('right').onclick = slideChange;
var slideNumber = 0;
function slideChange()
{
    slideNumber += 1;
    if (slideNumber > 3)
    {
        slideNumber = 1;
    }
    else
    {
        document.getElementById('main').src = 'http://lmetar.com/oscar' + slideNumber + '.jpg';
    }
}

Upvotes: 1

Views: 1125

Answers (2)

Kaspar Lee
Kaspar Lee

Reputation: 5596

Your JavaScript is loading before you content, therefore it is trying to find elements that do not exists. You have 2 options:

  1. Move your <script> tag to the end of your page
  2. Use the following to wait until the page has loaded before you execute your script

Code:

document.addEventListener("DOMContentLoaded", function(event) { 
  // Your Code Here
});

Upvotes: 0

j08691
j08691

Reputation: 207901

Move your script to the end of your page. You're running JavaScript on elements that don't yet exist.

Or wrap the code you have in a window.onload call which will execute the code after the window has loaded. Ex:

 window.onload = function () {
   document.getElementById('left').onclick = slideChange;
   document.getElementById('right').onclick = slideChange;
   var slideNumber = 0;

   function slideChange() {
     slideNumber += 1;
     if (slideNumber > 3) {
       slideNumber = 1;
     } else {
       document.getElementById('main').src = 'http://lmetar.com/oscar' + slideNumber + '.jpg';
     }
   }
 };

Upvotes: 6

Related Questions