CODEWITHSUNDEEP
javascriptgreasemonkeytampermonkey
CodeMonkey
CodeMonkey

Reputation: 81

Grease/tampermonkey script not working unless page refreshed

I frequent a forum that has a horrible way of ignoring users. If you place someone on ignore, it almost makes that users presence more prevalent.

So I wrote this to hide them completely:

// ==UserScript==
// @name         Freddie
// @namespace    http://tampermonkey.net/
// @version      0.1
// @description  hide annoying forum users
// @author       You
// @match        http://www.scout.com/college/kansas/forums/*
// @grant        none
// ==/UserScript==
/* jshint -W097 */

'use strict';

function checkForDiv() { // crappy workaround function to wait for AJAX content      
    if (!document.getElementById("wrapper")) {        
        setTimeout(checkForDiv, 300);   
    } else {       
        checkNames();   
    }
}

function checkNames() {  
    var mybannedList = ["Pyros", "GOHawksGators", "th30r3o"]; // add usernames  here
    var nms = document.body.querySelectorAll('a.authName'), i = 0, len =  nms.length;
    for (i; i < len; i++) {
        if (mybannedList.indexOf(nms[i].innerHTML) != -1) {
          nms[i].parentNode.parentNode.style.display = "none";
        }
    }
}

checkForDiv();

But when you go to the page with the ignored users they still appear, upon refreshing, the script runs and they disappear.

Please good sirs, what do I do?

Upvotes: 8

Views: 4090

Answers (1)

woxxom
woxxom

Reputation: 73566

The site uses AJAX for navigation so the page address changes without reloading, that's why Tampermonkey doesn't inject your script when you navigate from another page on that site.

The simplest solution would be to include the entire site: // @match http://www.scout.com/*

There are other more advanced methods of detecting page transitions based on MutationObserver or some DOM event or property change that occurs on navigation.

Also beware of @grant none with jQuery loaded via @require: it breaks sites that also load jQuery unless you use jQuery.noConflict. The simplest solution is to remove that line as you don't need to access the web page variables.

P.S. There's a known timer-based wrapper: waitForKeyElements.

Upvotes: 5

Related Questions