CODEWITHSUNDEEP
javascripthtml
Josias Menzel
Josias Menzel

Reputation: 1

External Javascript is not working

Let's keep this short and sweet.

Here is my header:

<head>
    <title>4JSB Assignment</title>
    <link rel="stylesheet" type="text/css" href="css/style.css">
    <script type="text/javascript" src="javascript/form.js"></script>
</head>

Note: <script type="text/javascript" src="javascript/form.js"></script>

Does not appear to be working.

I have a Submit button in the body that is part of a form. Here it is, located at the end of the aforementioned form:

<input type=submit name="submitForm" id="submitForm" onclick="submitForm()">

Here is my external javascript:

function submitForm() {
alert("Working");
}

Alas, "Working" never appears.

My folder structure is as follows:

root
    css
    ....style.css

    javascript
    ....form.js

    form.html

The answer is more than likely trivial, but has had me stuck on this assignment for hours because of this one requirement that the javascript be linked from an outside source. I appreciate any attempt to point out this mundane and unfortunate mishap to me.

Upvotes: 0

Views: 71

Answers (3)

Erwin O.
Erwin O.

Reputation: 309

It depends on what do you want to acomplish:

If you add a onclick function on your submit button it wont work for submit the form, so it will be pointless to have it as that.

If you want execute a javascript function before submit the form and or want to perform some validations that may or may not prevent the form for being submitted . The best way to do it:

<form onsubmit="return submitform();">
    ....
    <input type=submit name="submitFormAny" id="submitFormAny">
</form>

Also as other contributors were saying, be careful, you can't have elements and functions with same id's

Upvotes: 0

Jaromanda X
Jaromanda X

Reputation: 1

The issue is that you have id="submitForm" and function submitForm

Not sure why browsers do this, but any id is available as a global object

so, 

console.log(submitForm);

would show the input element, rather than the function!!

use a different name for the id, or for the function

console.log(submitForm) actually shows the function!! but it's still a name conflict in the end.

Upvotes: 3

Mark E
Mark E

Reputation: 730

Try changing the name and id of your submit button to something like "submitButton" so that it isn't exactly the same as your javascript function. I believe there is a name conflict.

Upvotes: 1

Related Questions