CODEWITHSUNDEEP
c++stringnull
activout.se
activout.se

Reputation: 6106

C++ string that can be NULL

I'm used to passing around string like this in my C++ applications:

void foo(const std::string& input)
{
  std::cout << input.size() << std::endl;
}

void bar()
{
  foo("stackoverflow");
}

Now I have a case where I want the string to be NULL:

void baz()
{
  foo("stackoverflow");
  foo(NULL); // very bad with foo implementation above
}

I could change foo to:

void foo(const std::string* input)
{
  // TODO: support NULL input
  std::cout << input->size() << std::endl;
}

But to pass a string literal or copy a char* to that implementation of foo I need to write something like this:

void bar()
{
  string input("hi"); // annoying temporary
  foo(&input);
  foo(NULL);  // will work as long as foo handles NULL properly
}

I started thinking about inheriting from std::string and adding a null property, but I'm not so sure it's a good idea. Maybe it is better to simply use a const char* string for parameters that can be NULL, but what if I want to save a copy of the string (or NULL) without having to manage its memory myself? (See What are some of the drawbacks to using C-style strings? etc.)

Any clever solution around?

Upvotes: 7

Views: 17947

Answers (7)

Tom
Tom

Reputation: 10819

Absolutely do not inherit from std::string. Inheritance is the tightest coupling you can have in C++, and you're only looking for nullability, which you can get simply with const char*, overloads, or simply std::string * if you really want.

Upvotes: 2

Max Lybbert
Max Lybbert

Reputation: 20039

Personally, I would change the semantics to pass around empty std::strings instead of NULL:

void foo(const std::string& input)
{
    if (!input.empty())
        std::cout << input.size() << std::endl;
}

void bar()
{
      foo("");
}

Upvotes: 10

Matt McClellan
Matt McClellan

Reputation: 1669

Or, mixing a bit of two previous answers:

void fooImpl( const char* input )
{
    if ( input != NULL )
        std::cout << input << std::endl;
}

void foo( const std::string& input )
{
    fooImpl(input.c_str());    
}

void foo( const char* input )
{
    fooImpl(input);
}

Same interface, no copy on the stack. You could, if you liked, inline fooImpl as well.

Upvotes: 3

eplawless
eplawless

Reputation: 4323

Function overloading to the rescue...

void foo( const std::string& input )
{
    std::cout << input << std::endl;

    // do more things ...
}

void foo( const char* input )
{
    if ( input != NULL ) foo( std::string(input) );
}

This will accept both c-style char arrays and std::strings, and will incur extra overhead on the stack if you pass in a string literal or a char array, but allows you to keep your implementation in one place and keep your nice syntax.

Upvotes: 11

Konrad Rudolph
Konrad Rudolph

Reputation: 545588

Why don't you overload the function and give the second overload no argument? Then both overloads can internally call a function that provides the read logic and that, itself, gets passed a pointer to std::string.

void foo_impl(string const* pstr) { … }

void foo(string const& str) {
    foo_impl(&str);
}

void foo() {
    foo_impl(0);
}

Upvotes: 2

Stack Overflow is garbage
Stack Overflow is garbage

Reputation: 247969

If you want the type to be null, then make it a pointer. Pass string pointers around instead of references, since this is precisely what pointers can do, and references cant. References always point to the same valid object. Pointers can be set to null, or be reseated to point to another object. Thus, if you need the things pointers can do, use pointers.

Alternatively, use boost::optional, which allows a more type-safe way to specify "this variable may or may not contain a value".

Or, of course, change the semantics so you either use empty strings instead of null, pass a separate bool parameter specifying whether the string is available or not, or refactor so you don't need this in the first place.

Upvotes: 20

Greg Hewgill
Greg Hewgill

Reputation: 993095

What if you just use:

void foo(const char *xinput)
{
    if (xinput == NULL) {
        // do something exceptional with this
        return;
    }
    std::string input(xinput);
    // remainder of code as usual
}

Yes, this does incur an extra allocation and copy, and calling the function is a bit more verbose because you need to use .c_str() in the usual case, but it does give you the semantics you want.

Upvotes: 1

Related Questions