linkNES
linkNES

Reputation: 113

Jquery hover image trouble when one image is clicked and then another image is clicked the first image clicked will not be displayed when hovered upon

Now I have a new problem when I click the desired image rating and then I click another desired rating and then I decide to hover over the first rating I clicked and now the star image rating I first clicked will not display.

For example lets say I clicked the 3 stars rating image and then I clicked the 1 star rating image and then I hover back over to the 3 star rating image the image will not appear when hovered.

HTML

<form method="" action="" id="rating-form">
  <fieldset>
    <ol>
      <li>
        <ul class="rating-pick notrated">
          <li id="rate-1" data-desc="Bad">
            <label for="rating-1">
              <input type="radio" value="1" name="rating" id="rating-1" />1 star</label>
          </li>
          <li id="rate-2" data-desc="Good">
            <label for="rating-2">
              <input type="radio" value="2" name="rating" id="rating-2" />2 stars</label>
          </li>
          <li id="rate-3" data-desc="Great">
            <label for="rating-3">
              <input type="radio" value="3" name="rating" id="rating-3" />3 stars</label>
          </li>
          <li id="rate-4" data-desc="Better">
            <label for="rating-4">
              <input type="radio" value="4" name="rating" id="rating-4" />4 stars</label>
          </li>
          <li id="rate-5" data-desc="Best">
            <label for="rating-5">
              <input type="radio" value="5" name="rating" id="rating-5" />5 stars</label>
          </li>
        </ul>
        <div class="rate" data-desc="Rate this product">Rate this product</div>
      </li>
    </ol>
  </fieldset>
</form>

Jquery

$(document).ready(function() {
  var rating;
  $('.rating-pick li')
    .on('mouseenter touchstart', function() {
      var classSuffix = $(this).find('input').attr('id').split('-')[1];
      $('.rating-pick').prevAll().addBack().addClass('rating-' + classSuffix);
      $('.rating-pick').nextAll().removeClass('notrated');
      $('.rate').text($(this).data('desc'));  
      rating = $('.rating-pick').attr('class').split(' ')[1];
      $('.rating-pick').removeClass(rating);
    })
    .on('mouseleave touchend', function() {
      var classSuffix = $(this).find('input').attr('id').split('-')[1];
      $('.rating-pick').prevAll().addBack().removeClass('rating-' + classSuffix);
      $('.rate').text($('.rate').attr('data-desc'));
      $('.rating-pick').addClass(rating);
    })
    .on('change click', function(e) {
      e.preventDefault();
      e.stopPropagation();
      $('.rate').attr('data-desc', $(this).attr('data-desc'));
      var classSuffix = $(this).find('input').attr('id').split('-')[1];
      $('ul.rating-pick').removeClass().addClass('rating-pick rating-' + classSuffix);
      $(this).off('mouseenter touchstart mouseleave touchend');
    });
});

CSS

*{
  margin: 0;
  padding: 0;
  border: 0;
}

#rating-form ol li{
  list-style: none;
  width: 100%;
  float: left;
}

#rating-form label{
    display: inline-block;
    margin-bottom: 0.2em;
    font-weight: bold;
    width: 100%;
}

.rate{
    float: left;
    width: 100%;
    margin: -1.4em 0 1.8em 0;
}

.rating-pick{
    width: 150px;
    height: 30px;
    float: left;
    margin-bottom: 1.8em;
}

.notrated{
    background-image: url('http://s8.postimg.org/xgfpw2679/stars.png');
    background-repeat: repeat-x;
    background-position: 0px 0px;
}


.rating-1{
    background-image: url('http://s8.postimg.org/xgfpw2679/stars.png');
    background-repeat: repeat-x;
    background-position: 0px -60px;
}

.rating-2{
    background-image: url('http://s8.postimg.org/xgfpw2679/stars.png');
    background-repeat: repeat-x;
    background-position: 0px -120px;
}

.rating-3{
    background-image: url('http://s8.postimg.org/xgfpw2679/stars.png');
    background-repeat: repeat-x;
    background-position: 0px -180px;
}

.rating-4{
    background-image: url('http://s8.postimg.org/xgfpw2679/stars.png');
    background-repeat: repeat-x;
    background-position: 0px -240px;
}

.rating-5{
    background-image: url('http://s8.postimg.org/xgfpw2679/stars.png');
    background-repeat: repeat-x;
    background-position: 0px -300px;
}

.rating-pick input[type="radio"], .rating-pick label{
    height: 0 !important;
    display: none !important;
}

.rating-pick li{
    float: left !important;
    width: 30px !important;
    height: 30px !important; 
    display: block !important;
    list-style-type: none !important;
    cursor: pointer !important;
}

Here is the code in action http://jsfiddle.net/v6kythze/

Upvotes: 2

Views: 61

Answers (2)

Ahs N
Ahs N

Reputation: 8366

This is the updated code:

$(document).ready(function() {
      var rating = "notrated";
      $('.rating-pick li')
        .on('mouseenter touchstart', function() {
          $(this).parent().removeClass($(this).parent().attr("class").split(" ")[1]);
          var classSuffix = $(this).attr('id').split('-')[1];
          $('.rating-pick').addClass('rating-' + classSuffix);
          $('.rate').text($(this).data('desc'));
        })
        .on('mouseleave touchend', function() {
          var classSuffix = $(this).attr('id').split('-')[1];
          $('.rate').text($('.rate').attr('data-desc'));
          $('.rating-pick').attr("class", "").addClass("rating-pick " + rating)
        })
        .on('change click', function(e) {
          e.preventDefault();
          e.stopPropagation();
          $('.rate').attr('data-desc', $(this).attr('data-desc'));
          rating = "rating-" + $(this).attr("id").split("-")[1];
          $('.rating-pick').removeClass("notrated").addClass(rating);
        });
    });

Here is the JSFiddle demo

The issue in your code was due to the fact that the events were being turned off on the elements.

I removed that code and implemented a work around.

Upvotes: 1

AVAVT
AVAVT

Reputation: 7133

Man I'm so lazy to write javascript today but your questions keep popping over and over again for hours so here, a working version for you:

$(document).ready(function() {
	  var rating;
	  $('.rating-pick li')
	    .on('mouseenter touchstart', function() {
	      var classSuffix = $(this).find('input').attr('id').split('-')[1];
	      $('.rating-pick').addClass('rating-hover-' + classSuffix);
	      $('.rate').text($(this).data('desc'));
	    })
	    .on('mouseleave touchend', function() {
	      var classSuffix = $(this).find('input').attr('id').split('-')[1];
	      $('.rating-pick').removeClass('rating-hover-' + classSuffix);
	      $('.rate').text($('.rate').attr('data-desc'));

	      $('.rating-pick').addClass(rating);
	    })
	    .on('change click', function(e) {
	      $('.rate').attr('data-desc', $(this).attr('data-desc'));
	      var classSuffix = $(this).find('input').attr('id').split('-')[1];
	      $('ul.rating-pick').removeClass().addClass('rating-pick rating-' + classSuffix);
	    });
	});
* {
  margin: 0;
  padding: 0;
  border: 0;
}
#rating-form ol li {
  list-style: none;
  float: left;
  width: 100%;
}
#rating-form label {
  display: inline-block;
  font-weight: bold;
  position: absolute;
  top: 0;
  left: 0;
  right: 0;
  bottom: 0;
  opacity: 0;
  cursor: pointer;
}

#rating-form label input{
  display: none;
}

.rate {
  float: left;
  width: 100%;
  margin: -1.4em 0 1.8em 0;
}
.rating-pick {
  width: 150px;
  height: 30px;
  float: left;
  margin-bottom: 1.8em;
  
  background-image: url('http://s8.postimg.org/xgfpw2679/stars.png');
  background-repeat: norepeat;
  background-position: 0px 0px;
}

.rating-1 {
  background-position: 0px -60px;
}
.rating-2 {
  background-position: 0px -120px;
}
.rating-3 {
  background-position: 0px -180px;
}
.rating-4 {
  background-position: 0px -240px;
}
.rating-5 {
  background-position: 0px -300px;
}

.notrated {
  background-position: 0px 0px;
}
.rating-hover-1 {
  background-position: 0px -60px;
}
.rating-hover-2 {
  background-position: 0px -120px;
}
.rating-hover-3 {
  background-position: 0px -180px;
}
.rating-hover-4 {
  background-position: 0px -240px;
}
.rating-hover-5 {
  background-position: 0px -300px;
}

#rating-form .rating-pick li{
  position: relative;
  width: 30px;
  height: 30px;
  display: block;
}
<script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script>
<form method="" action="" id="rating-form">
  <fieldset>
    <ol>
      <li>
        <ul class="rating-pick">
          <li id="rate-1" data-desc="Bad">
            <label for="rating-1">
              <input type="radio" value="1" name="rating" id="rating-1" />1 star</label>
          </li>
          <li id="rate-2" data-desc="Good">
            <label for="rating-2">
              <input type="radio" value="2" name="rating" id="rating-2" />2 stars</label>
          </li>
          <li id="rate-3" data-desc="Great">
            <label for="rating-3">
              <input type="radio" value="3" name="rating" id="rating-3" />3 stars</label>
          </li>
          <li id="rate-4" data-desc="Better">
            <label for="rating-4">
              <input type="radio" value="4" name="rating" id="rating-4" />4 stars</label>
          </li>
          <li id="rate-5" data-desc="Best">
            <label for="rating-5">
              <input type="radio" value="5" name="rating" id="rating-5" />5 stars</label>
          </li>
        </ul>
        <div class="rate" data-desc="Rate this product">Rate this product</div>
      </li>
    </ol>
  </fieldset>
</form>

Upvotes: 1

Related Questions