CODEWITHSUNDEEP
javascriptnode.jsrsspromisebluebird
Musical Shore
Musical Shore

Reputation: 1381

Should I explicitly create a promise when waiting for an event to fire?

I am writing a function to get an rss feed and return the date of the last update:

var FeedParser = require('feedparser'),
Promise = require('bluebird'),
request = require('request');

function getDate() {
    var deferred = Promise.defer();
    var feed = new FeedParser();
    request('rss.xml');
    .on('response',function() {
        this.pipe(feed);
    });

    feed.on('meta',function() {
        deferred.resolve(this.meta.date);
    });

    return deferred.promise;
}

Is this an anti-pattern? What is the proper way to do this?

Upvotes: 1

Views: 82

Answers (1)

idbehold
idbehold

Reputation: 17168

You can simplify it a bit.

var FeedParser = require('feedparser'),
Promise = require('bluebird'),
request = require('request');

function getDate() {
  return new Promise(function(resolve, reject){
    var feed = new FeedParser();
    request('rss.xml').on('error', reject).pipe(feed);
    feed.on('meta',function() {
      resolve(this.meta.date);
    }).on('error', reject);
  });
}

Upvotes: 3

Related Questions