CODEWITHSUNDEEP
python
Iura Rusu
Iura Rusu

Reputation: 95

Python script closes after some iterations

I wrote a piece of code and when I run it goes smooth until it gets to "czz", I am a beginner and I do not know what is the problem.. If someone could tell me what I am doing wrong. Basically the idea behind this code is to try to find all 3-letters domains available with ".ro" 

import urllib2
import urllib
import string

from urllib2 import Request, urlopen, URLError, HTTPError
from string import ascii_lowercase

f = open('3-letters.txt', 'w')

for x in ascii_lowercase:
    for y in ascii_lowercase:
        for z in ascii_lowercase:
            req = Request("http://"+x+y+z+".ro")

            try:
                response = urlopen(req)
            except HTTPError as e:
                f.write("http://"+x+y+z+".ro\n")
            except URLError as e:
                f.write("http://"+x+y+z+".ro\n")
            else:
                print "bad "+x+y+z


f.close();

Upvotes: 0

Views: 68

Answers (3)

timgeb
timgeb

Reputation: 78650

One problem is that you are not closing your connections after you don't need them any longer, you can do that with response.close(). Do that in a finally block to ensure it will always be executed.

try:
    # do stuff
except:
    # do stuff
finally:
    response.close()

In addition, here's a better way to generate all the three letter strings than your nested for loops:

>>> from string import ascii_lowercase
>>> from itertools import product
>>> three_letters = (''.join(x) for x in product(ascii_lowercase, repeat=3))
>>> for x in three_letters:
...     print(x)

'aaa'
'aab'
'aac'
'aad'
'aae'
...

Upvotes: 4

Vlad
Vlad

Reputation: 18633

You could try to add a timeout argument to urlopen:

response = urlopen(req, timeout=2)

For example, cze.ro seems to take forever.

Upvotes: 2

BCartolo
BCartolo

Reputation: 719

You have to close the connections.

response.close()

I hope you are not trying to spam or something.

Upvotes: 2

Related Questions