My while loops seems to be ignoring my getline

Question

Here's all the code

#include <iostream>
#include <string>
#include <windows.h>
#include <stdlib.h>
using namespace std;

void Pdelay(string str)
{
    for (char c : str)
    {
        std::cout << "" << c << "";
        Sleep(100);
    }
    std::cout << '\n';
}


int main()
{
    int exit = 1;
    while (exit == 1)
    {

        cout<< "Type something\n:";
        string str;
        str.clear();
        getline(cin,str);
        Pdelay(str);

        cout << "\n\n[1]Type something again"<< endl;
        cout << "[2]Exit\n:";

        cin >> exit;
    }
    return 0;
}

Whenever I run it, it works properly the first time round, when it loops back it skips the getline and continues with the two cout statements.

Answer 1

Immediately after you use cin, the newline remains in the buffer and is being "eaten" by the subsequent getline. You need to clear the buffer of that additional newline:

// immediately after cin (need to #include <limits>)
std::cin.ignore(std::numeric_limits<std::streamsize>::max(),'\n');

That's why it's not a very good idea to combine std::cin and std::getline. BTW, you can write your code in fully standard compliant C++11, with no additional non-library headers:

#include <chrono>
#include <iostream>
#include <limits>
#include <string>
#include <thread>

void Pdelay(std::string str)
{
    for (char c : str)
    {
        std::cout << "" << c << "" << std::flush;
        std::this_thread::sleep_for(std::chrono::milliseconds(100));
    }
    std::cout << '\n';
}

int main()
{
    int ext = 1;
    while (ext == 1)
    {
        std::cout << "Type something\n:";
        std::string str;
        str.clear();

        std::getline(std::cin, str);
        Pdelay(str);

        std::cout << "\n\n[1]Type something again" << std::endl;
        std::cout << "[2]Exit\n:";

        std::cin >> ext;
        if(!std::cin) // extraction failed
        {
            std::cin.clear(); // clear the stream
            ext = 1;
        }
        std::cin.ignore(std::numeric_limits<std::streamsize>::max(),'\n');
    }
}

I just realized that this question has been asked (in a slightly modified form) before, and the answers are great:

Why does std::getline() skip input after a formatted extraction?