CODEWITHSUNDEEP
javatry-with-resources
P45 Imminent
P45 Imminent

Reputation: 8591

Is the close method on a try-with-resources idiom not called if a constructor throws an exception?

I have a base class Base and a child class Child which extends it. Base implements java.lang.AutoCloseable.

Let's suppose that the constructor for Child throws a Foo.

Now consider

try (Base c = new Child()){
    /*Some code*/
} catch (final Foo e){
    /*Some more code*/
}

Is the Base#close method called if the exception is thrown? It is not on my machine, but is this something that the JLS has standardised?

Upvotes: 12

Views: 2837

Answers (3)

hfontanez
hfontanez

Reputation: 6168

This may not be the best way to handle it but MAYBE you could delay throwing the exception until AFTER the object is constructed. How? You could have an exception attribute on the class and add a clause to the class's public methods that if that exception attribute is not null, you could then throw the cached exception that originated during object instantiation. This way, you should be able to reclaim the resources that might have been allocated during the partial construction of the object in question. I believe this is how these IO readers and writers classes handle these cases.

Again, this might not be the best way, but it might be something to consider if you REALLY need to.

Upvotes: 0

Tunaki
Tunaki

Reputation: 137084

Yes, close won't be called. This is specified in the JLS section 14.20.3:

Resources are initialized in left-to-right order. If a resource fails to initialize (that is, its initializer expression throws an exception), then all resources initialized so far by the try-with-resources statement are closed. If all resources initialize successfully, the try block executes as normal and then all non-null resources of the try-with-resources statement are closed.

Resources are closed in the reverse order from that in which they were initialized. A resource is closed only if it initialized to a non-null value. An exception from the closing of one resource does not prevent the closing of other resources. Such an exception is suppressed if an exception was thrown previously by an initializer, the try block, or the closing of a resource.

In this case, an exception is thrown in the constructor so the resource is not initialized to a non-null value. Hence, the close method isn't called.

Upvotes: 16

user2357112
user2357112

Reputation: 280788

close will not be called. It wouldn't make sense to call it, since you don't have a fully-constructed object to close, and in similar calls, you might not have even entered a constructor:

try (Base b = makeBase()) {
    ...
}

where makeBase is

Base makeBase() {
    throw new RuntimeException();
}

Upvotes: 7

Related Questions