CODEWITHSUNDEEP
pythoncontrol-flowtry-catch-finally
Falmarri
Falmarri

Reputation: 48577

python try/finally for flow control

I'm sure this concept has come up before but I can't find a good, simple answer. Is using try/finally a bad way to handle functions with multiple returns? For example I have


try:
    if x:
        return update(1)
    else:
        return update(2)
finally:
    notifyUpdated()

This just seems nicer than storing update() commands in a temporary variable and returning that.

Upvotes: 5

Views: 1573

Answers (6)

John La Rooy
John La Rooy

Reputation: 304355

I think a decorator is a better idea here

def notifyupdateddecorator(f):
    def inner(*args, **kw):
        retval = f(*args, **kw)
        notifyUpdated()
        return retval
    return inner

@notifyupdateddecorator
def f(x):
    if x:
        return update(1)
    else:
        return update(2)

@notifyupdateddecorator
def g(x):
    return update(1 if x else 2)

Upvotes: 3

Omnifarious
Omnifarious

Reputation: 56068

I wouldn't recommend it. First because notifyUpdated() will be called even if the code in either branch throws an exception. You would need something like this to really get the intended behavior:

try:
    if x:
        return update(1)
    else:
        return update(2)
except:
    raise
else:
    notifyUpdated()

Secondly, because try blocks generally indicate you're doing some kind of exception handling, and you aren't, you're just using them for convenience. So this construct will confuse people.

For example, I don't think either of the first two people (at least one of which deleted their answer) to answer your question realized what you were really trying to do. Confusing code is bad, no matter how convenient and clever it seems.

Upvotes: 11

P Daddy
P Daddy

Reputation: 29537

I think this is asking for trouble. What happens later, when you change your code to the following?

try:
    if x:
        return update(1)
    elif y:
        return update(2)
    else:
        return noUpdateHere()
finally:
    notifyUpdated() # even if noUpdateHere()!

At best, it's a stumbling point for most readers of your code (probably even you in six months), because it's using try/finally for a purpose that differs from the normal use patterns. And the typing it saves is minimal, anyway.

Upvotes: 3

Ned Batchelder
Ned Batchelder

Reputation: 375764

I would not use try/finally for flow that doesn't involve exceptions. It's too tricky for its own good.

This is better:

if x:
    ret = update(1)
else:
    ret = update(2)
notifyUpdated()
return ret

Upvotes: 11

Wai Yip Tung
Wai Yip Tung

Reputation: 18774

I think you mean you want to use try/finally as an alternative to this:

if x:
    result = update(1)
else:
    result = update(2)
notifyUpdated()
return result

I guess this is a matter of style. For me I like to reserve try for handling exceptional conditional. I won't use it as a flow control statement.

Upvotes: 3

akonsu
akonsu

Reputation: 29566

from http://docs.python.org/library/contextlib.html:


from contextlib import closing
import urllib

with closing(urllib.urlopen('http://www.python.org')) as page:
    for line in page:
        print line

so you can create a similar function and use it

Upvotes: 0

Related Questions