CODEWITHSUNDEEP
csocketsopenssl
sigvardsen
sigvardsen

Reputation: 1531

SSL_read not receiving

I'm trying to connect to a secure service via SSL, however in the following code, the SSL_read never returns, this is of course normal behaviour if the server does not return any message, the server I am trying to connect to should however return some sort of message. Is there anything not allowing a read in the following?

//Initialize SSL library
OpenSSL_add_ssl_algorithms();
//Initialize Crypto algorithms
OpenSSL_add_all_algorithms();

//Create new SSL context accepting SSL V2, V3 or TLS V1.0, V1.1 and V1.2
const SSL_METHOD *method = SSLv23_client_method();
SSL_CTX *ctx = SSL_CTX_new(method);
if (ctx == NULL)
{
    printf("Error initializing SSL context.\n");
    return 0;
}
SSL *ssl = SSL_new(ctx);
//Create socket descriptor
int sd = 0;
//Create hints for connection
struct addrinfo hints;
memset(&hints, 0, sizeof(hints));
hints.ai_family = AF_UNSPEC;//Can be both IPv4 or IPv6
hints.ai_socktype = SOCK_STREAM;
hints.ai_protocol = IPPROTO_TCP;
struct addrinfo * result;
//Get address info, this could potentially return multiple
int err = getaddrinfo("api.okcoin.com", "9880", &hints, &result);
if (err != 0)
{
    printf("Could not get addr info.\n");
    return 0;
}
//Try connecting to any of the returned addresses
struct addrinfo * res;
for (res = result; res != NULL; res = res->ai_next)
{
    sd = socket(res->ai_family, res->ai_socktype, res->ai_protocol);
    if (sd == -1)
    {
        printf("Could not connect to host.\n");
        return 0;
    }
    if (connect(sd, res->ai_addr, res->ai_addrlen) == 0)
    {
        //Socket is now connected, free addrinfo results
        freeaddrinfo(result);
        //Assign socket descriptor to SSL
        if (SSL_set_fd(ssl, sd) == 0)
        {
            printf("Could not assign socket descriptor.\n");
            return 0;
        }
        //Begin SSL-handshake
        if(SSL_connect(ssl) == 0)
        {
            printf("Could not perform handshake.\n");
            return 0;
        }
        break;
    }
}
//Could not connect socket, free addrinfo results and return error
if (res == NULL)
{
    printf("Could no connect to to any host.\n");
    freeaddrinfo(result);
    return 0;
}
printf("Connected.\n");

SSL_write(ssl, "HELLO\x01", 6);
char * m = malloc(8192);
SSL_read(ssl, m, 8192);

Upvotes: 0

Views: 984

Answers (1)

user207421
user207421

Reputation: 311023

As there is no error checking, you have no way of knowing whether the SSL_write() succeeded, let alone why the SSL_read() is blocking. You can't write code like this at any time, let alone when dealing with networks or SSL.

What I get with an equivalent Java program is an untrusted server certificate error. When I fix that I get a read timeout after 60 seconds.

I conclude that it isn't your code that's at fault here but the request format.

Upvotes: 1

Related Questions