output html with echo

Question

i am echoing html with php echo

for example :

echo "<span onClick='popUpWin('add_page.php?id=".$row[Id]."', 'standard', '1000', '600',30,150)'><img src='images/editbtn.png' class='ddpngfix'></span>";

it is displaying data as it should be, my problem is when i click on image it is not calling function popUpWin, it is present on the same page, and when i checked in firebug inspect element it is showing span element totally broken, please check below image

i know quotes are making problem , How to solve this ?

Answer 1

Escape the 's properly -

echo "<span onClick=\"popUpWin('add_page.php?id=".$row['Id']."', 'standard', 1000, 600 ,30,150)\"><img src='images/editbtn.png' class='ddpngfix'></span>";

No need for 's around numbers.

Answer 2

Add " for onclick and escape it like below:

echo "<span onclick=\"popUpWin('add_page.php?id=".$row['Id']."', 'standard', 1000, 600 ,30,150)\"><img src='images/editbtn.png' class='ddpngfix'></span>";